changed TOF-related interfile keywords #62
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add facility to add an alias for a keyword. This just works by looking-up the keyword in a map. This meansss type and callback remain the same. Also minor clean-up of test_KeyParser
use hopefully clearer names: - new: "TOF mashing factor", old: "%TOF mashing factor" - new: "Maximum number of (unmashed) TOF time bins", old: "Number of TOF time bins" - new: "Size of unmashed TOF time bins (ps)", old: "Size of timing bin (ps)" Old keywords are entered as aliases until STIR 7.0
KrisThielemans
force-pushed
the
TOF_interfile_keywords
branch
from
91effad to
4192f33
Compare
Looks good. Do these needed to be added to the docs/glossary? |
|
That's a great idea. In fact, STIR-glossary.tex needs TOF info in other places. I'll have a look. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
use hopefully clearer names to avoid confusion when TOF mashing is used
Old keywords are entered as aliases until STIR 7.0 (which means a warning will be issued if you use them).
@danieldeidda, @NicoleJurjew, @NikEfth, @robbietuk, what do you think about these new names?