Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decimal separator fix for Edit Alert #3819

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Navid200
Copy link
Collaborator

@Navid200 Navid200 commented Dec 17, 2024

This is an alternative approach with respect to: #2998

I have used tolerantParseDouble().
In the following table you can see the behaviors before and after.
Please pay attention at the very end to the fractional part, which is dropped before but, is preserved after.

Before After
https://github.com/user-attachments/assets/db8b902d-00de-4221-b43a-c728c86db490 https://github.com/user-attachments/assets/a7c622e9-d6be-48e0-b217-77efedba744a

@Navid200
Copy link
Collaborator Author

I tested using the alert that I created above with its threshold set to 4.5. It works as expected.

Screenshot_20241217-185407

Screenshot_20241217-185344

@Navid200 Navid200 changed the title Decimal separator - Edit Alert Decimal separator fix for Edit Alert Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant