PERFORMANCE: Removed ValueStringBuilder and reworked methods that used it to use stack/array pool explicitly#85

Merged

NightOwl888 merged 21 commits intomainfrom perf/remove-valuestringbuilderindexer

Jan 6, 2024

+1,452-2,417

Commits on Jan 4, 2024

Directory.Build.targets: Added FEATURE_STRINGBUILDER_COPYTO_SPAN so we can track whether it makes sense to use the stack when comparing StringBuilder chars.
NightOwl888
committed
PERFORMANCE: J2N.Character.OffsetByCodepoints(): Switched from ValueStringBuilderIndexer to using stack/array pool for comparing chars
NightOwl888
committed
PERFORMANCE: J2N.Character.CodePointCount(): Switched from ValueStringBuilderIndexer to using stack/array pool for comparing chars
NightOwl888
committed
J2N.Character: Removed ValueStringBuilderIndexer overloads for CodePointAt() and CodePointBefore(): Updated documentation on StringBuilder overloads to recommend calling the ReadOnlySpan<char>, str…
NightOwl888
committed
PERFORMANCE: J2N.Text.StringExtensions (RegionMatches + ContentEquals): Switched from ValueStringBuilderIndexer to using stack/array pool for comparing chars
NightOwl888
committed
PERFORMANCE: J2N.Text.StringExtensions::CompareToOrdinal(StringBuilder): Switched from ValueStringBuilderIndexer to using stack/array pool for comparing chars
NightOwl888
committed
PERFORMANCE: J2N.Text.CharArrayExtensions::CompareToOrdinal(StringBuilder): Switched from ValueStringBuilderIndexer to using stack/array pool for comparing chars
NightOwl888
committed
PERFORMANCE: J2N.Text.CharArrayExtensions::Subsequence(): Use Array.Copy() instead of a for loop for better performance
NightOwl888
committed
PERFORMANCE: J2N.Text.StringBuilderExtensions::CompareToOrdinal(): Switched from ValueStringBuilderIndexer to using stack/array pool for comparing chars
NightOwl888
committed
PERFORMANCE: J2N.Text.StringBuilderExtensions (IndexOf() + LastIndexOf()): Switched from ValueStringBuilderIndexer to using stack/array pool for comparing chars
NightOwl888
committed
PERFORMANCE: J2N.StringBuilderExtensions::Replace(): Removed the call to ValueStringBuilderIndexer, since it negatively impacts performance
NightOwl888
committed
PERFORMANCE: J2N.Text.StringBuilderExtensions::Reverse(): Copy the chars out of the StringBuilder, then append them back in reverse order. This has much better performance than attempting to index …
NightOwl888
committed
PERFORMANCE: J2N.Text (CharArrayCharSequence + StringBuilderCharSequence + StringCharSequence)::Equals(): Switched from ValueStringBuilderIndexer to using stack/array pool for comparing chars
NightOwl888
committed
PERFORMANCE: J2N.Text.CharSequenceComparer: Switched from ValueStringBuilderIndexer to using stack/array pool for comparing chars
NightOwl888
committed
PERFORMANCE: J2N.Text.StringBuilderExtensions::Replace(): Use GetChunks() (when supported) to update the StringBuilder via index to keep from having to do a lookup on each character.
NightOwl888
committed

Commits on Jan 5, 2024

Commits on Jan 6, 2024

J2N.Text.StringBuilderExtensions:Insert(): Removed incorrect comments from StringBuilder overloads. There are no Insert() overloads that accept StringBuilder in the BCL (only Append).
NightOwl888
committed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

PERFORMANCE: Removed ValueStringBuilder and reworked methods that used it to use stack/array pool explicitly#85

Commits on Jan 4, 2024

Directory.Build.targets: Added FEATURE_STRINGBUILDER_COPYTO_SPAN so we can track whether it makes sense to use the stack when comparing StringBuilder chars.

PERFORMANCE: J2N.Character.OffsetByCodepoints(): Switched from ValueStringBuilderIndexer to using stack/array pool for comparing chars

PERFORMANCE: J2N.Character.CodePointCount(): Switched from ValueStringBuilderIndexer to using stack/array pool for comparing chars

J2N.Character: Removed ValueStringBuilderIndexer overloads for CodePointAt() and CodePointBefore(): Updated documentation on StringBuilder overloads to recommend calling the ReadOnlySpan<char>, str…

PERFORMANCE: J2N.Text.StringExtensions (RegionMatches + ContentEquals): Switched from ValueStringBuilderIndexer to using stack/array pool for comparing chars

PERFORMANCE: J2N.Text.StringExtensions::CompareToOrdinal(StringBuilder): Switched from ValueStringBuilderIndexer to using stack/array pool for comparing chars

PERFORMANCE: J2N.Text.CharArrayExtensions::CompareToOrdinal(StringBuilder): Switched from ValueStringBuilderIndexer to using stack/array pool for comparing chars

PERFORMANCE: J2N.Text.CharArrayExtensions::Subsequence(): Use Array.Copy() instead of a for loop for better performance

PERFORMANCE: J2N.Text.StringBuilderExtensions::CompareToOrdinal(): Switched from ValueStringBuilderIndexer to using stack/array pool for comparing chars

PERFORMANCE: J2N.Text.StringBuilderExtensions (IndexOf() + LastIndexOf()): Switched from ValueStringBuilderIndexer to using stack/array pool for comparing chars

PERFORMANCE: J2N.StringBuilderExtensions::Replace(): Removed the call to ValueStringBuilderIndexer, since it negatively impacts performance

PERFORMANCE: J2N.Text.StringBuilderExtensions::Reverse(): Copy the chars out of the StringBuilder, then append them back in reverse order. This has much better performance than attempting to index …

PERFORMANCE: J2N.Text (CharArrayCharSequence + StringBuilderCharSequence + StringCharSequence)::Equals(): Switched from ValueStringBuilderIndexer to using stack/array pool for comparing chars

PERFORMANCE: J2N.Text.CharSequenceComparer: Switched from ValueStringBuilderIndexer to using stack/array pool for comparing chars

PERFORMANCE: J2N.Text.StringBuilderExtensions::Replace(): Use GetChunks() (when supported) to update the StringBuilder via index to keep from having to do a lookup on each character.

Commits on Jan 5, 2024

BUG: J2N.Text.StringBuilderExtensions: We need to be explicit when cascading calls because Insert(object?) and Append(object?) take precedence over extension methods that accept ICharSequence and S…

J2N.Character::ToString(): Use MemoryMarshal.GetReference() when dealing with pointers to Span<T> and ReadOnlySpan<T>

J2N.Memory.MemoryExtensions::ReverseText(): Use MemoryMarshal.GetReference() when dealing with pointers to Span<T> and ReadOnlySpan<T>

J2N.Text: Removed ValueStringBuilderIndexer, ValueStringBuilderChunkIndexer, and ValueStringBuilderChunkedArrayIndexer.

J2N.Memory: Removed Int32Packer and ValueInt32Packer.

Commits on Jan 6, 2024

J2N.Text.StringBuilderExtensions:Insert(): Removed incorrect comments from StringBuilder overloads. There are no Insert() overloads that accept StringBuilder in the BCL (only Append).