Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Task: Add tests/target for net8.0 #94

Closed
NightOwl888 opened this issue Aug 14, 2024 · 0 comments · Fixed by #110
Closed

Task: Add tests/target for net8.0 #94

NightOwl888 opened this issue Aug 14, 2024 · 0 comments · Fixed by #110
Assignees
@NightOwl888
Labels
is:enhancement New feature or request pri:high
Milestone
2.1

Comments

@NightOwl888
Copy link
Owner

For the vNext, we will need to target and add tests for the latest LTS of .NET, net8.0.

This task involves the following:

  1. Add net8.0 target to the J2N and J2N.TestFramework projects. Also, the TestTargetFramework.props file (including documentation).
  2. Review and add net8.0 API features in the root Directory.Build.targets file. Note that most (if not all) features of net6.0 will carry over to net8.0. This should make it possible to compile and run the tests for net8.0.
  3. Update the publish-test-results-for-target-frameworks.yml file to include an entry for net8.0.
  4. Update the run-tests-on-os.yml file to include the x86 installation code for each target framework (example for net6.0). We will need this for all versions of .NET Core, since the .NET 8 SDK no longer includes x86 support by default.
@NightOwl888 NightOwl888 added is:enhancement New feature or request pri:high up for grabs This issue is open to be worked on by anyone labels Aug 14, 2024
@NightOwl888 NightOwl888 added this to the 2.1 milestone Aug 14, 2024
@NightOwl888 NightOwl888 self-assigned this Aug 21, 2024
@NightOwl888 NightOwl888 removed the up for grabs This issue is open to be worked on by anyone label Aug 21, 2024
NightOwl888 added a commit that referenced this issue Sep 16, 2024
@NightOwl888
Added net8.0 target and tests (fixes #94)
423e103
@NightOwl888 NightOwl888 mentioned this issue Sep 16, 2024
Merged
@NightOwl888 NightOwl888 mentioned this issue Nov 6, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@NightOwl888 NightOwl888

Labels
is:enhancement New feature or request pri:high
Projects
None yet
Milestone
2.1
Development

Successfully merging a pull request may close this issue.

Added net8.0 target and tests (Fixes #94) NightOwl888/J2N
1 participant
@NightOwl888