feat: Add exception tag list for global drag handle #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HanCiHu
force-pushed
the
feature/add-except-tag
branch
from
e0d17db to
445016b
Compare
HanCiHu
force-pushed
the
feature/add-except-tag
branch
from
445016b to
dfdf3e6
Compare
|
lgtm, but I would remove ‘ol’, ‘ul’ from the default excludedTags list, otherwise it may cause confusion as ol and ul list items are draggable and these tags are used internally and are mandatory to avoid flickering of the handle in lists. Please also update the README |
HanCiHu
force-pushed
the
feature/add-except-tag
branch
from
3742755 to
9299bc0
Compare
|
Thanks for your comment ! |
HanCiHu
force-pushed
the
feature/add-except-tag
branch
from
9299bc0 to
f2d08aa
Compare
HanCiHu
force-pushed
the
feature/add-except-tag
branch
from
f2d08aa to
8660fa2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello, I've been using global drag handle in tiptap really well !!
If I want to hide the drag handle on some elements, I can add a
not-draggableclass, but If I want to hide it for all specific tags, it's unmanageable to add a class for every tag.So how about getting the tags developers want to hide as options?