Phn2annot fixes #75
Merged
Phn2annot fixes #75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
change `phn2annot` function so that it checks for both `.wav` and `.WAV` files when opening the file to determine the sampling rate, which it does to convert samples to seconds for onsets and offsets fixes bug on some versions of TIMIT dataset where audio files end in .WAV instead of .wav
`soundfile` is able to parse the NIST format .WAV files in addition to standard `.wav` files, so the function should now work regardless of which version of TIMIT dataset user has (will add tests to verify this)
modify the `crowsetta.validation._parse_file` function
so that the type of the `extension` argument can be
not just a string but also a tuple of strings
this way other functions can specify a set of valid
extensions, e.g. `('.phn', '.PHN')`, not just `'.phn'`.
Makes it possible for e.g. `phn2annot` to act in a
"case-insensitive" way, converting both `.phn` and
`.PHN` files
NickleDave
added a commit
that referenced
this pull request
Jan 12, 2021
NickleDave
added a commit
that referenced
this pull request
Jan 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.