Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOTFIX][BE]: Fix unmitigated Guzzle timeout error #294

Merged
merged 1 commit into from
Dec 1, 2024

Conversation

Nicklas373
Copy link
Owner

Changelog:

  • Add timeout into http request (5 minutes) by default, this to mitigate default http timeout from guzzle (30 seconds). Due un-predicted Aspose API response
  • Add handler when timeout already running out to return proper error message and avoid backend server crashes
  • Merge function convert to xlsx and pptx into one function

- Add timeout into http request (5 minutes) by default, this to mitigate default
http timeout from guzzle (30 seconds). Due un-predicted Aspose API response
- Add handler when timeout already running out to return proper error message and avoid
backend server crashes
- Merge function convert to xlsx and pptx into one function
Signed-off-by: Dicky Herlambang (花) <herlambangdicky5@gmail.com>
@Nicklas373 Nicklas373 added the bug Something isn't working label Dec 1, 2024
@Nicklas373 Nicklas373 self-assigned this Dec 1, 2024
@Nicklas373 Nicklas373 merged commit 03a8079 into be/master Dec 1, 2024
1 check passed
@Nicklas373 Nicklas373 deleted the dev/be/master branch December 1, 2024 10:42
@Nicklas373 Nicklas373 restored the dev/be/master branch December 1, 2024 10:43
Nicklas373 added a commit that referenced this pull request Dec 2, 2024
Changelog:

- Increase timeout into http request (30 seconds) by default, this to
mitigate current http timeout (3 seconds)
- Add handler when timeout already running out to return proper error
message and avoid backend server crashes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant