C++ style enums 7/N: MeasureMode (facebook#1389)

Summary:
X-link: facebook/react-native#39452

Pull Request resolved: facebook#1389

This converts usages of YGMeasureMode to MeasureMode

Reviewed By: rozele

Differential Revision: D49271165

fbshipit-source-id: a6ab7509a3f74bc6e1c42c0ce3376e1e7447f4dd

tests/YGNodeCallbackTest.cpp

@@ -38,7 +38,7 @@ TEST(Node, measure_with_measure_fn) {
       });
 
   ASSERT_EQ(
-      n.measure(23, YGMeasureModeExactly, 24, YGMeasureModeAtMost),
+      n.measure(23, MeasureMode::Exactly, 24, MeasureMode::AtMost),
       (YGSize{23, 12}));
 }
 

yoga/Yoga.cpp

@@ -905,13 +905,13 @@ bool YGNodeCanUseCachedMeasurement(
     float marginColumn,
     YGConfigRef config) {
   return yoga::canUseCachedMeasurement(
-      widthMode,
+      scopedEnum(widthMode),
       availableWidth,
-      heightMode,
+      scopedEnum(heightMode),
       availableHeight,
-      lastWidthMode,
+      scopedEnum(lastWidthMode),
       lastAvailableWidth,
-      lastHeightMode,
+      scopedEnum(lastHeightMode),
       lastAvailableHeight,
       lastComputedWidth,
       lastComputedHeight,

yoga/algorithm/Cache.cpp

@@ -5,52 +5,50 @@
  * LICENSE file in the root directory of this source tree.
  */
 
-#include <yoga/Yoga.h>
-
 #include <yoga/algorithm/Cache.h>
 #include <yoga/algorithm/PixelGrid.h>
 #include <yoga/numeric/Comparison.h>
 
 namespace facebook::yoga {
 
 static inline bool sizeIsExactAndMatchesOldMeasuredSize(
-    YGMeasureMode sizeMode,
+    MeasureMode sizeMode,
     float size,
     float lastComputedSize) {
-  return sizeMode == YGMeasureModeExactly &&
+  return sizeMode == MeasureMode::Exactly &&
       yoga::inexactEquals(size, lastComputedSize);
 }
 
 static inline bool oldSizeIsUnspecifiedAndStillFits(
-    YGMeasureMode sizeMode,
+    MeasureMode sizeMode,
     float size,
-    YGMeasureMode lastSizeMode,
+    MeasureMode lastSizeMode,
     float lastComputedSize) {
-  return sizeMode == YGMeasureModeAtMost &&
-      lastSizeMode == YGMeasureModeUndefined &&
+  return sizeMode == MeasureMode::AtMost &&
+      lastSizeMode == MeasureMode::Undefined &&
       (size >= lastComputedSize || yoga::inexactEquals(size, lastComputedSize));
 }
 
 static inline bool newMeasureSizeIsStricterAndStillValid(
-    YGMeasureMode sizeMode,
+    MeasureMode sizeMode,
     float size,
-    YGMeasureMode lastSizeMode,
+    MeasureMode lastSizeMode,
     float lastSize,
     float lastComputedSize) {
-  return lastSizeMode == YGMeasureModeAtMost &&
-      sizeMode == YGMeasureModeAtMost && !std::isnan(lastSize) &&
+  return lastSizeMode == MeasureMode::AtMost &&
+      sizeMode == MeasureMode::AtMost && !std::isnan(lastSize) &&
       !std::isnan(size) && !std::isnan(lastComputedSize) && lastSize > size &&
       (lastComputedSize <= size || yoga::inexactEquals(size, lastComputedSize));
 }
 
 bool canUseCachedMeasurement(
-    const YGMeasureMode widthMode,
+    const MeasureMode widthMode,
     const float availableWidth,
-    const YGMeasureMode heightMode,
+    const MeasureMode heightMode,
     const float availableHeight,
-    const YGMeasureMode lastWidthMode,
+    const MeasureMode lastWidthMode,
     const float lastAvailableWidth,
-    const YGMeasureMode lastHeightMode,
+    const MeasureMode lastHeightMode,
     const float lastAvailableHeight,
     const float lastComputedWidth,
     const float lastComputedHeight,

yoga/algorithm/Cache.h

@@ -7,19 +7,19 @@
 
 #pragma once
 
-#include <yoga/Yoga.h>
 #include <yoga/config/Config.h>
+#include <yoga/enums/MeasureMode.h>
 
 namespace facebook::yoga {
 
 bool canUseCachedMeasurement(
-    YGMeasureMode widthMode,
+    MeasureMode widthMode,
     float availableWidth,
-    YGMeasureMode heightMode,
+    MeasureMode heightMode,
     float availableHeight,
-    YGMeasureMode lastWidthMode,
+    MeasureMode lastWidthMode,
     float lastAvailableWidth,
-    YGMeasureMode lastHeightMode,
+    MeasureMode lastHeightMode,
     float lastAvailableHeight,
     float lastComputedWidth,
     float lastComputedHeight,