Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously track names in track controller were the single source of truth, tags were removed on song load and (re)created on save.
In the new approach, P and DUETSINGERP tags are present in the tag list all the time. Track name update triggers multiplayer tags value update/creation. Tag update triggers track name update. On both song load and save the tags are not manipulated at all.
By default when track name is changed in track controller, the app:
Using new property in settings, the default created tag can be changed back to DUETSINGERP (but only if txt format version specified by #VERSION tag is undefined, because since version 1.0.0 only P tags are allowed).
Minor fix - while track name was being edited, it was possible to choose "delete" option from this track's context menu, which resulted in exception in logs. Now context menu is disabled during edit.