Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/player tag name handling #53

Merged
merged 7 commits into from
Oct 7, 2024
Merged

Conversation

Nianna
Copy link
Owner

@Nianna Nianna commented Oct 7, 2024

Previously track names in track controller were the single source of truth, tags were removed on song load and (re)created on save.

In the new approach, P and DUETSINGERP tags are present in the tag list all the time. Track name update triggers multiplayer tags value update/creation. Tag update triggers track name update. On both song load and save the tags are not manipulated at all.
By default when track name is changed in track controller, the app:

  • updates both DUETSINGERP and P tags (if already present)
  • removes both DUETSINGERP and P tags (if present and the track name is cleared/set to default value)
  • adds P tag if it is missing
    Using new property in settings, the default created tag can be changed back to DUETSINGERP (but only if txt format version specified by #VERSION tag is undefined, because since version 1.0.0 only P tags are allowed).

Minor fix - while track name was being edited, it was possible to choose "delete" option from this track's context menu, which resulted in exception in logs. Now context menu is disabled during edit.

@Nianna Nianna merged commit 462657b into master Oct 7, 2024
1 check passed
@Nianna Nianna deleted the fix/player-tag-name-handling branch October 7, 2024 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant