Skip to content

Commit

Permalink
Fix duplicated dialog.edit_filenames.title key & add missing command.…
Browse files Browse the repository at this point in the history
…rename key (#31)
  • Loading branch information
Nianna authored Jul 16, 2023
1 parent e9cea10 commit 3c0052e
Show file tree
Hide file tree
Showing 5 changed files with 8 additions and 5 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ protected void onAction(ActionEvent event) {
}

private Command commandFromResults(EditFilenamesDialog.FilenamesEditResult result) {
return new CommandComposite(I18N.get("ui.common.rename")) {
return new CommandComposite(I18N.get("command.rename")) {

@Override
protected void buildSubCommands() {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,7 @@ public class EditFilenamesDialog extends ValidatedDialog<FilenamesEditResult> {
private boolean hideBackground = false;

public EditFilenamesDialog() {
setTitle(I18N.get("dialog.edit_filenames.title"));
setTitle(I18N.get("dialog.edit_filenames.dialog-title"));
DialogUtils.loadPane(this,
getClass().getResource("/fxml/EditFilenamesDialogPaneLayout.fxml"));

Expand Down
3 changes: 2 additions & 1 deletion src/main/resources/messages.properties
Original file line number Diff line number Diff line change
Expand Up @@ -176,7 +176,7 @@ dialog.creator.set_bpm.title=Set BPM
dialog.creator.set_bpm.header=Please set your song''s BPM
dialog.creator.set_bpm.description=Please specify the BPM (beats per minute) tempo of your song.\n You can obtain the correct value with dedicated programs like MixMeister BPM Analyzer.\n Higher BPM means higher accuracy and therefore better final result, but too big a value can unnecessarily complicate the process of creation.\nIt may also hinder Ultrastar''s performance.\n You should double the obtained BPM till if falls into the generally accepted optimal range of 200-400.\n\nYou may also skip this step by setting the default value of 240, but this practice is NOT recommended.
dialog.edit_filenames.title=Rename...
dialog.edit_filenames.dialog-title=Rename...
dialog.edit_filenames.artist=Artist:
dialog.edit_filenames.title=Title:
dialog.edit_filenames.filename=Filename:
Expand Down Expand Up @@ -268,6 +268,7 @@ command.split_note=Split note
command.roll_right=Roll lyrics right
command.roll_left=Roll lyrics left
command.resize=Resize notes
command.rename=Rename files
command.move=Move {0}
command.merge=Merge notes
command.join_notes=Join notes
Expand Down
3 changes: 2 additions & 1 deletion src/main/resources/messages_en_GB.properties
Original file line number Diff line number Diff line change
Expand Up @@ -176,7 +176,7 @@ dialog.creator.set_bpm.title=Set BPM
dialog.creator.set_bpm.header=Please set your song''s BPM
dialog.creator.set_bpm.description=Please specify the BPM (beats per minute) tempo of your song.\n You can obtain the correct value with dedicated programs like MixMeister BPM Analyzer.\n Higher BPM means higher accuracy and therefore better final result, but too big a value can unnecessarily complicate the process of creation.\nIt may also hinder Ultrastar''s performance.\n You should double the obtained BPM till if falls into the generally accepted optimal range of 200-400.\n\nYou may also skip this step by setting the default value of 240, but this practice is NOT recommended.
dialog.edit_filenames.title=Rename...
dialog.edit_filenames.dialog-title=Rename...
dialog.edit_filenames.artist=Artist:
dialog.edit_filenames.title=Title:
dialog.edit_filenames.filename=Filename:
Expand Down Expand Up @@ -268,6 +268,7 @@ command.split_note=Split note
command.roll_right=Roll lyrics right
command.roll_left=Roll lyrics left
command.resize=Resize notes
command.rename=Rename files
command.move=Move {0}
command.merge=Merge notes
command.join_notes=Join notes
Expand Down
3 changes: 2 additions & 1 deletion src/main/resources/messages_pl_PL.properties
Original file line number Diff line number Diff line change
Expand Up @@ -176,7 +176,7 @@ dialog.creator.set_bpm.title=Ustaw BPM
dialog.creator.set_bpm.header=Ustaw w\u0142a\u015Bciw\u0105 warto\u015B\u0107 BPM
dialog.creator.set_bpm.description=Prosz\u0119 podaj warto\u015B\u0107 BPM (liczb\u0119 uderze\u0144 na minut\u0119) odpowiedni\u0105 dla tej piosenki.\n Mo\u017Cesz j\u0105 sprawdzi\u0107 przy pomocy dedykowanych programów, takich jak MixMeister BPM Analyzer.\n Wy\u017Csze BPM oznacza wi\u0119ksz\u0105 dok\u0142adno\u015B\u0107, a co za tym idzie lepszy rezultat, ale zbyt du\u017Ca warto\u015B\u0107 mo\u017Ce niepotrzebnie skomplikowa\u0107 proces tworzenia. Mo\u017Ce tak\u017Ce negatywnie wp\u0142yn\u0105\u0107 na wydajno\u015B\u0107 UltraStara.\n Podwój otrzyman\u0105 warto\u015B\u0107 a\u017C znajdzie si\u0119 ona w zalecanym przedziale (200-400).\n\nMo\u017Cesz pomin\u0105\u0107 ten krok, ustawiaj\u0105c domy\u015Bln\u0105 warto\u015B\u0107 równ\u0105 240, jednak jest to ODRADZANE.

dialog.edit_filenames.title=Zmie\u0144 nazw\u0119...
dialog.edit_filenames.dialog-title=Zmie\u0144 nazw\u0119...
dialog.edit_filenames.artist=Artysta:
dialog.edit_filenames.title=Tytu\u0142:
dialog.edit_filenames.filename=Nazwa pliku:
Expand Down Expand Up @@ -273,6 +273,7 @@ command.split_note=Podziel nut\u0119
command.roll_right=Przewi\u0144 tekst w prawo
command.roll_left=Przewi\u0144 tekst w lewo
command.resize=Zmie\u0144 rozmiar nuty
command.rename=Zmie\u0144 nazw\u0119
command.move=Przesu\u0144 w {0}
command.merge=Scal nuty
command.join_notes=Z\u0142\u0105cz nuty
Expand Down

0 comments on commit 3c0052e

Please sign in to comment.