Decode HTML entities when copying text to clipboard (fixes #1850) #1855
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Integral-Tech
force-pushed
the
fix-html
branch
from
e874268 to
2d34332
Compare
Integral-Tech
changed the title
Integral-Tech
force-pushed
the
fix-html
branch
from
628f861 to
d7cdd8d
Compare
…rn#1850) Currently, when using `Copy` in the context menu, the text will be HTML escaped (e.g. `"` becomes `"`). Add a function to decode HTML entities when copying to clipboard. This PR fixes issue Nheko-Reborn#1850.
Integral-Tech
force-pushed
the
fix-html
branch
from
d7cdd8d to
6143d11
Compare
deepbluev7
reviewed
Jan 18, 2025
| void | ||
| Clipboard::setHtmlText(QString text) | ||
| { | ||
| setText(QTextDocumentFragment::fromHtml(text).toPlainText()); |
There was a problem hiding this comment.
The proper solution probably uses setMimeData and QMimeData::setHtml? I also am not sure if we always pass html text as text to the menu. It could be that some of it is actual plain text. We also possibly need to deal with inline images not getting resolved well?
There was a problem hiding this comment.
I've just tried this code, but it doesn't work:
QMimeData* mimeData = new QMimeData();
mimeData->setHtml(text);
QGuiApplication::clipboard()->setMimeData(mimeData);
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, when using
Copyin the context menu, the text will be HTML escaped (e.g."becomes"). Add a function to decode HTML entities when copying to clipboard.This PR fixes issue #1850.