Skip to content

Conversation

chrismaffey
Copy link
Contributor

the pass_auth and satisfy_any properties and now boolean true/false, they do not == 1 so the switching in this template breaks

the pass_auth and satisfy_any properties and now boolean true/false, they do not == 1 so the switching in this template breaks
@nginxproxymanagerci
Copy link

Docker Image for build 1 is available on
DockerHub
as nginxproxymanager/nginx-proxy-manager-dev:pr-4107

Note: ensure you backup your NPM instance before testing this image! Especially if there are database changes
Note: this is a different docker image namespace than the official image

@jc21
Copy link
Member

jc21 commented Oct 24, 2024

Good catch

@jc21 jc21 merged commit d17c85e into NginxProxyManager:develop Oct 24, 2024
1 check passed
@chrismaffey
Copy link
Contributor Author

Cool. That is the first time I have contributed code to an open source project! I hope it is useful.

@snuggles4553
Copy link

This looks weird:

{% if access_list.pass_auth == 0 or access_list.pass_auth == true %}

Shouldn't it be:

{% if access_list.pass_auth == 0 or access_list.pass_auth == false %}

(The other fix looks fine.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants