Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

02-app > 02-api-reference > 05-next-config-js > rewrites.mdx #414

Merged
merged 23 commits into from
Jul 28, 2023

Conversation

naringst
Copy link
Contributor

@naringst naringst commented Jul 10, 2023

기여자용

문서 개선

Progress

@haileyport
Copy link
Contributor

ref #96

Copy link
Contributor

@sungh0lim sungh0lim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

분량이 엄청 많았네요! 수고하셨습니다 :yay:
내용 확인했고 리뷰남깁니다. 확인부탁드리겠습니다 :)

Copy link
Contributor

@sungh0lim sungh0lim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

분량이 엄청 많았네요! 수고하셨습니다 :yay:
내용 확인했고 리뷰남깁니다. 확인부탁드리겠습니다 :)

naringst and others added 16 commits July 20, 2023 19:21
🔨fix : 리뷰반영(매핑해줍니다 -> 연결합니다)

Co-authored-by: 임성호 <70130721+sungh0lim@users.noreply.github.com>
🔨fix : 리뷰 반영(함수 -> 키)

Co-authored-by: 임성호 <70130721+sungh0lim@users.noreply.github.com>
🔨fix : 리뷰반영(배열들 -> 배열)

Co-authored-by: 임성호 <70130721+sungh0lim@users.noreply.github.com>
🔨fix : 리뷰반영('그리고' -> ',')

Co-authored-by: 임성호 <70130721+sungh0lim@users.noreply.github.com>
🔨fix : 리뷰반영(점차 -> 점진적으로)

Co-authored-by: 임성호 <70130721+sungh0lim@users.noreply.github.com>
🔨fix : 리뷰반영(알아두기-> 주의, e.g -> 예)

Co-authored-by: 임성호 <70130721+sungh0lim@users.noreply.github.com>
🔨fix : 리뷰반영('이들'삭제)

Co-authored-by: 임성호 <70130721+sungh0lim@users.noreply.github.com>
🔨fix : 리뷰반영( '이들' 삭제)

Co-authored-by: 임성호 <70130721+sungh0lim@users.noreply.github.com>
🔨fix : 리뷰반영(알아두면 좋은 것 -> 참고)

Co-authored-by: 임성호 <70130721+sungh0lim@users.noreply.github.com>
🔨fix : 리뷰반영(경로->라우트)

Co-authored-by: 임성호 <70130721+sungh0lim@users.noreply.github.com>
🔨fix : 리뷰반영('만약' 삭제)

Co-authored-by: 임성호 <70130721+sungh0lim@users.noreply.github.com>
🔨fix : 리뷰반영('만약' 삭제)

Co-authored-by: 임성호 <70130721+sungh0lim@users.noreply.github.com>
🔨fix : 리뷰반영('만약' 삭제)

Co-authored-by: 임성호 <70130721+sungh0lim@users.noreply.github.com>
🔨fix : 리뷰반영(알아두면 좋은 것 -> 참고)

Co-authored-by: 임성호 <70130721+sungh0lim@users.noreply.github.com>
@naringst
Copy link
Contributor Author

@sungh0lim 리뷰 내용 중 제가 댓글 달아 둔 한 부분 제외하고 모두 반영했습니다. 확인 부탁드립니다!

@sungh0lim
Copy link
Contributor

내용중에 ,가 없어도 될 곳에 있는 경우가 보이는데 같이 확인부탁드리겠습니다.

@naringst
Copy link
Contributor Author

최종 변경 완료하였습니다 😊

@naringst naringst requested a review from sungh0lim July 26, 2023 14:04
@sungh0lim
Copy link
Contributor

최종 변경 완료하였습니다 😊

LGTM 👍 고생많으셨습니다. Approve 남겨두겠습니다. (대기하시면 머지담당자가 머지해주실 예정입니다.)

@yoo-jimin127 yoo-jimin127 merged commit fa1f8a7 into Nextjs-kr:main Jul 28, 2023
@yoo-jimin127 yoo-jimin127 mentioned this pull request Jul 28, 2023
@naringst naringst deleted the nari-rewrites branch July 31, 2023 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants