Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

03-pages > 02-api-reference > 03-next-config-js > compress.mdx 번역 #382

Merged
merged 3 commits into from
Aug 9, 2023
Merged

03-pages > 02-api-reference > 03-next-config-js > compress.mdx 번역 #382

merged 3 commits into from
Aug 9, 2023

Conversation

ryukyung
Copy link
Contributor

@ryukyung ryukyung commented Jul 1, 2023 •
edited
Loading

기여자용

문서 개선

Progress #194

@ChanghyeonYoon ChanghyeonYoon added the documentation 문서 작업 label Jul 1, 2023
@haileyport haileyport mentioned this pull request Jul 3, 2023
Open
chaejunlee
chaejunlee approved these changes Jul 24, 2023
View reviewed changes
Copy link
Contributor

@chaejunlee chaejunlee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

기여해주셔서 감사합니다! 깔끔한 번역 확인했습니다! 바로 머지하도록 하겠습니다.

@chaejunlee chaejunlee self-requested a review July 24, 2023 16:03
chaejunlee
chaejunlee suggested changes Jul 24, 2023
View reviewed changes
Copy link
Contributor

@chaejunlee chaejunlee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

번역 요청을 pages 문서로 해주신 것으로 확인 됩니다! 그런데 app 문서를 번역해주셨네요 ㅠㅠ app 부분은 할당된 다른 분이 먼저 기여해주신 것으로 확인됩니다. 혹시 pages 문서로 다시 번역해주실 수 있을까요?

@chaejunlee chaejunlee added the duplicate App, Pages 공통 문서 label Jul 24, 2023
@ryukyung
Copy link
Contributor Author

ryukyung commented Aug 2, 2023

늦게 확인했습니다ㅠㅠ pages 문서로 다시 번역하였습니다!

@chaejunlee chaejunlee self-requested a review August 8, 2023 12:12
chaejunlee
chaejunlee approved these changes Aug 8, 2023
View reviewed changes
Copy link
Contributor

@chaejunlee chaejunlee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

리뷰 반영해주셔서 감사합니다! Approve 남기겠습니다!! 수고 많으셨습니다.

yoo-jimin127
yoo-jimin127 approved these changes Aug 9, 2023
View reviewed changes
Copy link
Contributor

@yoo-jimin127 yoo-jimin127 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!! 수고 많으셨습니다 ☺️👍
추가로 번역 희망하시는 챕터의 경우 이슈에 작성해주셔도 됩니다!!

@yoo-jimin127 yoo-jimin127 merged commit b60da6c into Nextjs-kr:main Aug 9, 2023
@yoo-jimin127
Copy link
Contributor

ref #194

@yoo-jimin127 yoo-jimin127 mentioned this pull request Aug 9, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chaejunlee chaejunlee chaejunlee approved these changes

@yoo-jimin127 yoo-jimin127 yoo-jimin127 approved these changes

@ChanghyeonYoon ChanghyeonYoon Awaiting requested review from ChanghyeonYoon ChanghyeonYoon is a code owner

Assignees

@ryukyung ryukyung

Labels
documentation 문서 작업 duplicate App, Pages 공통 문서
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ryukyung @yoo-jimin127 @chaejunlee @ChanghyeonYoon