Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

03-pages > 01-building-your-application > 07-deploying > 04-ci-build-caching.mdx #107 #372

Merged
merged 6 commits into from
Aug 9, 2023

Conversation

marvelopers
Copy link
Contributor

@marvelopers marvelopers commented Jun 30, 2023

기여자용

문서 개선

Progress

@sunmerrr sunmerrr requested review from sunmerrr and removed request for ChanghyeonYoon July 20, 2023 11:03

To take advantage of this cache in Continuous Integration (CI) environments, your CI workflow will need to be configured to correctly persist the cache between builds.
CI (지속적 통합) 환경에서 캐시를 활용하려면, CI 워크플로우를 올바르게 구성하여 빌드 사이에 캐시를 올바르게 유지하도록 설정해야 합니다.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

쉼표를 똑같이 옮길 필요는 없습니다. 이런 경우에는 빼는게 더 자연스러운 것 같은데 어떻게 생각하시나요? 참고

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

해당 줄 외에도 쉼표가 똑같이 옮겨진 곳도 있는데 해당 부분은 괜찮다고 생각하신게 맞으시죵? @marvelopers 더블체크 입니다:)

@sunmerrr
Copy link
Contributor

@marvelopers 수고하셨습니다!! 리뷰 확인 부탁드려요 :)

@marvelopers
Copy link
Contributor Author

@sunmerrr 리뷰 내용 반영했습니다 확인 부탁드립니다 :)

@marvelopers
Copy link
Contributor Author

@sunmerrr 리뷰 반영된 부분 확인 리마인드 드립니다 :)

@sunmerrr
Copy link
Contributor

sunmerrr commented Aug 9, 2023

@marvelopers 확인이 늦어져서 죄송해요!! 모두 확인했습니다. 수고 많으셨어요 :))

@marvelopers marvelopers merged commit b1b7b48 into Nextjs-kr:main Aug 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

04-ci-build-caching.mdx
3 participants