Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

02-app > 02-api-reference > 04-functions > use-selected-layout-segments.mdx #319

Merged
merged 4 commits into from
Jul 11, 2023

Conversation

devmmin
Copy link
Contributor

@devmmin devmmin commented Jun 27, 2023

기여자용

문서 개선

Progress

@haileyport
Copy link
Contributor

ref #139

Copy link
Contributor

@YuriKwon YuriKwon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다!! 👍🏻
리뷰 확인 및 반영 부탁드립니다!
바뀌는 문장들에 대해서 맞춤법 검사도 다시 한번씩 해주시면 좋을 것 같아요 :)

@devmmin
Copy link
Contributor Author

devmmin commented Jul 7, 2023

@YuriKwon 유리님 정말 감사합니다! 고생하셨습니다! 반영하겠습니다!

@devmmin
Copy link
Contributor Author

devmmin commented Jul 8, 2023

@YuriKwon 유리님! 코멘트 달아주신 내용 모두 적용 후에 프리티어 fix와 맞춤법 검사까지 완료 후 커밋 푸시 했습니다!! 감사합니다!!

분명 깃 유저 정보 잘 세팅했는데... 회사 계정으로 커밋이 되었네용...
혹시 몰라 참고로 TMI 공유 드립니다...

Copy link
Contributor

@yoo-jimin127 yoo-jimin127 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !! 리뷰 반영사항 잘 확인하였습니다 :) 정말 수고 많으셨어요 !! 👍
추가로 할당 희망하시는 티켓은 이슈에 작성해주셔도 됩니다 !!

@yoo-jimin127 yoo-jimin127 merged commit e0a142b into Nextjs-kr:main Jul 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants