Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

02-app > 02-api-reference > 04-functions > use-params.mdx #280

Merged
merged 6 commits into from
Jul 11, 2023
Merged

02-app > 02-api-reference > 04-functions > use-params.mdx #280

merged 6 commits into from
Jul 11, 2023

Conversation

94sssh
Copy link
Contributor

@94sssh 94sssh commented Jun 26, 2023 •
edited
Loading

기여자용

문서 개선

Progress

@ChanghyeonYoon ChanghyeonYoon added the documentation 문서 작업 label Jun 27, 2023
@haileyport
Copy link
Contributor

ref #47

@haileyport haileyport mentioned this pull request Jun 30, 2023
Open
chldmswnl
chldmswnl reviewed Jun 30, 2023
View reviewed changes
docs/02-app/02-api-reference/04-functions/use-params.mdx

```tsx
const params = useParams()
```

`useParams` does not take any parameters.
`useParams`는 어떤 매개변수도 받지 않습니다.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'어떤'보다는 '어떠한'이 조금 더 자연스러운것 같은데 어떻게 생각하시나요?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

두 단어가 의미상으로 차이가 없어 무엇을 사용해도 상관없을 것 같습니다.

@chaejunlee chaejunlee self-requested a review July 2, 2023 08:49
chaejunlee
chaejunlee reviewed Jul 2, 2023
View reviewed changes
Copy link
Contributor

@chaejunlee chaejunlee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

기여해주셔서 감사합니다! 몇 가지 사항 확인하여 커멘트 남겨드렸습니다! 확인 및 수정 부탁드립니다!

docs/02-app/02-api-reference/04-functions/use-params.mdx Outdated Show resolved Hide resolved
docs/02-app/02-api-reference/04-functions/use-params.mdx Outdated Show resolved Hide resolved
docs/02-app/02-api-reference/04-functions/use-params.mdx Outdated Show resolved Hide resolved
docs/02-app/02-api-reference/04-functions/use-params.mdx Outdated Show resolved Hide resolved
94sssh and others added 4 commits July 3, 2023 13:20
@94sssh @chaejunlee
리뷰 반영
9f65ef7 
Co-authored-by: 이채준 - CJ Lee <chaejunlee@knu.ac.kr>
@94sssh @chaejunlee
리뷰 반영
03c9abc 
Co-authored-by: 이채준 - CJ Lee <chaejunlee@knu.ac.kr>
@94sssh @chaejunlee
리뷰 반영
09c2426 
Co-authored-by: 이채준 - CJ Lee <chaejunlee@knu.ac.kr>
@94sssh @chaejunlee
리뷰 반영
3042c06 
Co-authored-by: 이채준 - CJ Lee <chaejunlee@knu.ac.kr>
@94sssh
Copy link
Contributor Author

94sssh commented Jul 3, 2023

감사합니다. 코멘트 모두 확인 및 해당 사항 커밋하였습니다!

yoo-jimin127
yoo-jimin127 approved these changes Jul 11, 2023
View reviewed changes
Copy link
Contributor

@yoo-jimin127 yoo-jimin127 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ! 수고 많으셨습니다 :) 👍
추가로 할당 희망하시는 티켓은 이슈에 작성해주셔도 됩니다 !!

@yoo-jimin127 yoo-jimin127 merged commit 17f6868 into Nextjs-kr:main Jul 11, 2023
@yoo-jimin127 yoo-jimin127 mentioned this pull request Jul 11, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chaejunlee chaejunlee chaejunlee left review comments

@chldmswnl chldmswnl chldmswnl left review comments

@yoo-jimin127 yoo-jimin127 yoo-jimin127 approved these changes

@ChanghyeonYoon ChanghyeonYoon Awaiting requested review from ChanghyeonYoon ChanghyeonYoon is a code owner

Assignees

@94sssh 94sssh

Labels
documentation 문서 작업 In Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@94sssh @haileyport @chaejunlee @chldmswnl @yoo-jimin127 @ChanghyeonYoon