Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

02-app - 02-api-reference - 02-file-conventions - page.mdx #205

Merged
merged 2 commits into from
Jun 27, 2023

Conversation

hanyugeon
Copy link
Contributor

@hanyugeon hanyugeon commented Jun 23, 2023

close #78

기여자용

문서 개선

Progress


| URL | `searchParams` |
| --------------- | -------------------- |
| `/shop?a=1` | `{ a: '1' }` |
| `/shop?a=1&b=2` | `{ a: '1', b: '2' }` |
| `/shop?a=1&a=2` | `{ a: ['1', '2'] }` |

> **Good to know**:
> **알아두면 좋은 정보**
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이전 PR들을 참고해보니
Good to know참고 또는 알아두면 좋은 점 으로 번역되어있었으나
리드미에서는 알아두면 좋은 정보로 표기되어있어 일단 리드미 내용대로 작성하였습니다.

Copy link
Contributor Author

@hanyugeon hanyugeon Jun 24, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

변경 사항에 따라 참고로 번역하도록 하겠습니다!


An object containing the [dynamic route parameters](/docs/app/building-your-application/routing/dynamic-routes) from the root segment down to that page. For example:
루트 세그먼트에서 해당 페이지까지의 [동적 루트 파라미터](/docs/app/building-your-application/routing/dynamic-routes)가 포함된 객체입니다. 다음 예제를 보세요.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

root segment를 발음 그대로 루트 세그먼트로 번역하였는데 괜찮을지

여러분들의 의견이 궁금합니다.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

변역한 루트 세그먼트(root segment)동적 루트 파라미터(dynamic route parameters)에서

한글로 작성된 루트
영어에서는 각각 root, route로 표기법이 달라
독자가 헷갈리지 않을까 걱정이네요 🤔

여러분들의 의견이 궁금합니다.

Copy link

@blissful-y0 blissful-y0 Jun 23, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

root는 루트, route는 라우트로 표기하는 것이 어떨까요?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

다른 번역을 진행하다 비슷한 고민을 했었는데요, 한국어 맞춤법에 돌려보니 라우터로 쓰라는 이야기가 있긴하더라구요.
영어 -> 한글로 변환한 것을 맛춤법 검사를 한 것이라, 일단은 라우터로 작업하긴 했는데 라우트로 가는 것도 좋아보입니다. 이것 확정해주시면 제 작업에서도 f/up하겠습니다! 🙇‍♂️

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@blissful-y0 @KunHwanAhn 의견 감사합니다!! route라우트로 표기하는것으로 해보겠습니다!


| URL | `searchParams` |
| --------------- | -------------------- |
| `/shop?a=1` | `{ a: '1' }` |
| `/shop?a=1&b=2` | `{ a: '1', b: '2' }` |
| `/shop?a=1&a=2` | `{ a: ['1', '2'] }` |

> **Good to know**:
> **알아두면 좋은 정보**
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

링크1, 링크2에서 "알아두면 좋은 정보" 가 아닌 "참고" 가이드라인이 작성되어 있습니다~! "참고"로 변경 부탁드려요.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

참고로 바뀌었네요!! 반영하도록하겠습니다 감사합니다!

Copy link
Contributor

@ChanghyeonYoon ChanghyeonYoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨습니다! 리뷰 반영 부탁드립니다!

@@ -25,33 +25,33 @@ export default function Page({ params, searchParams }) {

## Props

### `params` (optional)
### `params` (옵션)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

옵션보단 선택사항 이 좋을 듯 합니당

Copy link
Contributor Author

@hanyugeon hanyugeon Jun 24, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이부분도 고민이였는데 선택사항이 더 적절해 보이네요 감사합니다!!

| ------------------------------------ | ----------- | ------------------------------ |
| `app/shop/[slug]/page.js` | `/shop/1` | `{ slug: '1' }` |
| `app/shop/[category]/[item]/page.js` | `/shop/1/2` | `{ category: '1', item: '2' }` |
| `app/shop/[...slug]/page.js` | `/shop/1/2` | `{ slug: ['1', '2'] }` |

### `searchParams` (optional)
### `searchParams` (옵션)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

선택사항


An object containing the [search parameters](https://developer.mozilla.org/en-US/docs/Learn/Common_questions/What_is_a_URL#parameters) of the current URL. For example:
현재 URL의 [검색 매개변수](https://developer.mozilla.org/en-US/docs/Learn/Common_questions/What_is_a_URL#parameters)가 포함된 객체입니다. 다음 예제를 보세요.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

참고로 수정해주시고 parameters는 파라미터로 수정 부탁드립니다! 실제 업무에서 매개변수란 말보단 파라미터라도 그대로 읽는 경우가 많으니까요!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ChanghyeonYoon
아래 PR에 남긴 코멘트 참고 부탁드립니다~! 🙏

Copy link
Contributor Author

@hanyugeon hanyugeon Jun 24, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ChanghyeonYoon 이슈 템플릿 용어 확인 링크에 있는 내용에 따라 매개변수로 작성하였는데
@KunHwanAhn 님이 언급해주신 링크처럼 자세한 내용이 궁금합니다!!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

앗 매개변수로 해주세요!!!제가 깜빡했네요 ㅠㅠ @hanyugeon

@hanyugeon
Copy link
Contributor Author

@ChanghyeonYoon 리뷰 부탁드립니다!!

Copy link
Contributor

@ChanghyeonYoon ChanghyeonYoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
수고하셨습니다! 추가로 하시고 싶은 티켓이 있다면 신청해주셔도 됩니다!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation 문서 작업
Projects
None yet
Development

Successfully merging this pull request may close these issues.

page.mdx
5 participants