Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

01-codemods.mdx 번역 #178

Merged
merged 3 commits into from
Jun 22, 2023
Merged

01-codemods.mdx 번역 #178

merged 3 commits into from
Jun 22, 2023

Conversation

LAH1203
Copy link
Contributor

@LAH1203 LAH1203 commented Jun 22, 2023

기여자용

문서 개선

Progress

@LAH1203
Copy link
Contributor Author

LAH1203 commented Jun 22, 2023

몇 가지 본래 쓰인 단어를 번역했을 때와 의미가 살짝 맞지 않아 초월 번역한 부분이 있습니다. 그 부분 참고해서 리뷰해주시면 감사하겠습니다 :)

import Image1 from 'next/legacy/image'
// 'next/future/image' becomes 'next/image'
// 'next/future/image''next/image'로 바뀝니다
Copy link
Contributor

@HA-SEUNG-JEONG HA-SEUNG-JEONG Jun 22, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

피동형 문장에 주의하세요. 에 따라 'next/future/image'를 'next/image'로 바꿉니다.
라고 하는게 더 올바른 표현이 아닌가 싶습니다!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

오 좋은 의견 감사합니다! 같은 코드 주석과 함께 수정하겠습니다~

@ChanghyeonYoon ChanghyeonYoon linked an issue Jun 22, 2023 that may be closed by this pull request
@ChanghyeonYoon ChanghyeonYoon added the documentation 문서 작업 label Jun 22, 2023
Copy link
Contributor

@ChanghyeonYoon ChanghyeonYoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
수고하셨습니다! 추가로 하시고 싶은 티켓이 있다면 신청해주셔도 됩니다!

@ChanghyeonYoon ChanghyeonYoon merged commit a36f9b0 into Nextjs-kr:main Jun 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation 문서 작업
Projects
None yet
Development

Successfully merging this pull request may close these issues.

01-codemods.mdx
3 participants