refactor: 미션 인증 정렬/검증 로직 리팩토링 #78
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
+) 검증 단위 테스트는 작성했는데 정렬 단위 테스트는 아직이에요...! 빠르게 작성해볼게요 💦 |
songyi00
approved these changes
Aug 22, 2024
src/main/java/com/nexters/goalpanzi/application/mission/MissionVerificationValidator.java
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Number
close: #77
작업 개요
미션 인증/정렬 로직 리팩토링
작업 사항
MissionVerification의 서비스 단에서 모든 정렬을 수행하면서 서비스 코드가 복잡해짐MissionVerificationResponseSorter를 정의하여 서비스 코드와 정렬 로직을 분리함MissionVerificationValidator를 정의하여 서비스 코드와 검증 로직을 분리함고민한 점들(필수 X)
MissionValidator코드처럼MissionVerificationValidator도 있으면 좋을 것 같아 같이 리팩토링 진행했습니다..!+) 참여 로직 잠시 주석 처리하고 e2e 테스트 돌렸을 때 정상적으로 돌아갔습니다! (생성자 새롭게 정의해서 테스트 코드도 작성해보겠습니다..!)
스크린샷(필수 X)