Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: 미션 인증 피드 API 틀 구현 #74

Merged
merged 16 commits into from
Aug 21, 2024

Conversation

songyi00
Copy link
Member

@songyi00 songyi00 commented Aug 18, 2024

Issue Number

close: #68

작업 개요

  • @kimyu0218 요 브랜치 위에서 하면 됩니당

작업 사항

여기에 작성하세요

고민한 점들(필수 X)

@songyi00
단위 테스트를 해보려고 했는데 entity에서 다른 entity를 참조하다 보니 id값이 없는 entity는 null로 판단하는 것 같아요..! 😢😢
테스트는 못했지만 swagger도 봐야 하니까 merge부터 해야 할지 고민입니다.

//  MEMBER_* : id값이 없는 entity

List<MissionMember> missionMembers = List.of(
        new MissionMember(MEMBER_HOST, mission, 1),
        new MissionMember(MEMBER_A, mission, 1),
        new MissionMember(MEMBER_B, mission, 1)
);
// mock(Member.class)를 이용해서 특정 id값을 반환하도록 해도 이미 getMember()부터 null

private List<MissionVerificationResponse> sortMissionVerifications(final Member member, final MissionVerificationQuery.SortType sortType, final Sort.Direction direction, final List<MissionVerification> missionVerifications, final List<MissionMember> missionMembers) {
    List<MissionVerificationResponse> response = new ArrayList<>();
    Map<Long, MissionVerification> map = missionVerifications.stream()
            .collect(Collectors.toMap(missionVerification -> missionVerification.getMember().getId(), missionVerification -> missionVerification));
    ...
}

스크린샷(필수 X)

@songyi00 songyi00 force-pushed the feat/#68-verification-view-api branch from 337d9bb to 2d58e1b Compare August 18, 2024 09:11
@kimyu0218 kimyu0218 merged commit 83fa4d8 into develop Aug 21, 2024
1 check passed
@kimyu0218 kimyu0218 deleted the feat/#68-verification-view-api branch August 21, 2024 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

미션 인증 피드 확인 API
3 participants