Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build for mac x64 and arm64 separately and update mac deploy docs #366

Merged
merged 10 commits into from
Sep 18, 2023

Conversation

rly
Copy link
Collaborator

@rly rly commented Sep 14, 2023

Ref: #309

Building separate dmg files for x64 and arm64 may not be necessary. Needs more testing, but I am caching my progress here.

See also electron-userland/electron-builder#5689 (comment)

@rly rly marked this pull request as ready for review September 18, 2023 18:17
@rly rly changed the title [WIP] Build for mac x64 and arm64 and update mac deploy docs Build for mac x64 and arm64 separately and update mac deploy docs Sep 18, 2023
@rly
Copy link
Collaborator Author

rly commented Sep 18, 2023

Update: After updating the certificates and credentials, Apple no longer complains about code signing and notarization on MacOS during the build process. Further testing needed to see whether the x64 and arm64 dmg files run correctly on their respective systems and do not trigger mac security warnings.

@CodyCBakerPhD
Copy link
Collaborator

Building separate dmg files for x64 and arm64 may not be necessary.

I still suspect we might need this for those handful of interfaces that struggle with M1

But this is working well for me ATM, will raise any other issues as they occur

Thanks a bunch! @rly

@CodyCBakerPhD CodyCBakerPhD linked an issue Sep 18, 2023 that may be closed by this pull request
@CodyCBakerPhD CodyCBakerPhD merged commit 71484b5 into main Sep 18, 2023
@CodyCBakerPhD CodyCBakerPhD deleted the doc-and-osx-arm64 branch September 18, 2023 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mac Certification
2 participants