Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added -sbml-sedml option passing through to jnml #295

Merged
merged 2 commits into from
Feb 7, 2024

Conversation

robertvi
Copy link
Contributor

A simple pass through of -sbml-sedml from pynml to jnml

@sanjayankur31
Copy link
Member

sanjayankur31 commented Feb 6, 2024

@robertvi : I've just merged development into this to (hopefully) fix the CI. Please run a git pull in your local copy to get the latest version.

This looks fine to me, but I think we need to wait for a new jNeuroML release before merging this in, since that's required for the options to be available in jnml.

@pgleeson pgleeson merged commit b437dea into NeuroML:development Feb 7, 2024
5 checks passed
@pgleeson
Copy link
Member

pgleeson commented Feb 7, 2024

@sanjayankur31 nope, -sbml-sedml has been an option in jnml for a long time...

@sanjayankur31
Copy link
Member

Cool, I'll cut a quick release then so all of this gets to users now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants