Account for unidirectional spiketrain->segment links in synchrofact deletion #398
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
when passing the actual segment.spiketrains list to the Synchrotool and performing in-place deletion the spiketrain was overwritten before its index was determined resulting in an error
if the spiketrain is not part of a segment and/or block the `continue` skipped the replacement in the input list
in in-place synchrofact deletion: catch ValueError and raise UserWarning instead
dizcza
reviewed
Jan 29, 2021
dizcza
approved these changes
Feb 1, 2021
dizcza
added
bugfix
ackurth
pushed a commit
to INM-6/elephant
that referenced
this pull request
Oct 1, 2021
…eletion (NeuralEnsemble#398) * Fix a bug in synchrofact deletion when passing the actual segment.spiketrains list to the Synchrotool and performing in-place deletion the spiketrain was overwritten before its index was determined resulting in an error * Fix spiketrain replacement being skipped if the spiketrain is not part of a segment and/or block the `continue` skipped the replacement in the input list * Handle unidirectional segment uplinks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See NeuralEnsemble/python-neo#939 for an in-depth description and a minimal example.
This ensures that no error is raised for neo structures with unidirectional uplinks (which can still happen even if this is changed in neo, e.g. if people use an older version or modify the structure manually). The user is warned about the unidirectional link.
This also fixes a bug which occurred when the Synchrotool was initialised with the actual spiketrain list of a segment, so
Synchrotool(segment.spiketrains, ...). Due to the execution order in the in-place deletion, the spiketrain was replaced in the list before its index was extracted, resulting in the same error as above.