fix(users): prevent NPE while retrieving unknown user (#24)

NeuraLegion · Aug 24, 2022 · ef7127e · ef7127e
1 parent d7aba1d
commit ef7127e
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/src/users/users.service.ts b/src/users/users.service.ts
@@ -31,7 +31,7 @@ export class UsersService {
    * you can fix the actual issue:
    * ```ts
    * public findOne(id: number): Promise<User | null> {
-   *   return this.orm.em.findOne({ id });
+   *   return this.orm.em.findOne(User, { id });
    * }
    * ```
    *
@@ -42,7 +42,7 @@ export class UsersService {
    *    .getConnection()
    *    .execute(`select * from "user" where "id" = ?`, [id]);
    *
-   *   return this.orm.em.map(User, user);
+   *   return user ? this.orm.em.map(User, user) : null;
    * }
    * ```
    */
@@ -51,7 +51,7 @@ export class UsersService {
       .getConnection()
       .execute(`select * from "user" where "id" = ${id}`);
 
-    return this.orm.em.map(User, user);
+    return user ? this.orm.em.map(User, user) : null;
   }
 
   public async remove(id: number): Promise<void> {