feat(plugin): make plugin a "no-op" in unsupported browsers #460
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Code Climate has analyzed commit d5d5ea9 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 92.4%. View more on Code Climate. |
derevnjuk
changed the title
Sija
suggested changes
Sep 13, 2024
derevnjuk
requested changes
Sep 13, 2024
We now enforce the precondition immediately, before we do anything else. This ensures the precondition error wouldn't be masked by a different problem.
Without proper setup, this test would start failing if we change the behavior to be a "no-op" in unsupported browsers.
rmacklin
force-pushed
the
make-it-a-no-op-in-unsupported-browsers
branch
from
2c2f3ca to
22e6cdf
Compare
Previously the plugin would throw an error when it was running in an unsupported browser. This was not great for plugin consumers who run their cypress tests in both supported and unsupported browsers and are fine with only having HAR recording in supported browsers: It forced them to conditionally enable this plugin. To address this, we're changing the plugin to do nothing except `warn` that HAR recording is not supported when running in an unsupported browser.
rmacklin
force-pushed
the
make-it-a-no-op-in-unsupported-browsers
branch
from
22e6cdf to
d5d5ea9
Compare
derevnjuk
approved these changes
Sep 16, 2024
Sija
approved these changes
Sep 16, 2024
|
@rmacklin thanks for contributing! Great work 💪🏾 |
|
Thank you @derevnjuk! Hoping to switch away from my fork as soon as there's a new release published :) Edit: Oh, I see you already done that - awesome! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #5 (comment)
Previously the plugin would throw an error when it was running in an unsupported browser. This was not great for plugin consumers who run their cypress tests in both supported and unsupported browsers and are fine with only having HAR recording in supported browsers: It forced them to conditionally enable this plugin.
To address this, we're changing the plugin to do nothing except
warnthat HAR recording is not supported when running in an unsupported browser.