Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(*): add timeout flag to all commands #597

Merged
merged 2 commits into from
Sep 10, 2024
Merged

feat(*): add timeout flag to all commands #597

merged 2 commits into from
Sep 10, 2024

Conversation

maksadbek
Copy link
Collaborator

No description provided.

@maksadbek maksadbek added the Type: enhancement New feature or request. label Sep 9, 2024
@maksadbek maksadbek requested a review from derevnjuk September 9, 2024 22:20
@maksadbek maksadbek self-assigned this Sep 9, 2024
@derevnjuk
Copy link
Member

@maksadbek, please change the PR type to feat since you are altering the expected behavior. This is hardly a bug fix.

@maksadbek maksadbek changed the title fix(*): add timeout flag to all commands feat(*): add timeout flag to all commands Sep 10, 2024
derevnjuk
derevnjuk reviewed Sep 10, 2024
View reviewed changes
src/Config/CliBuilder.ts Outdated Show resolved Hide resolved
src/Commands/StopScan.ts Outdated Show resolved Hide resolved
@derevnjuk derevnjuk enabled auto-merge (squash) September 10, 2024 07:40
@derevnjuk derevnjuk merged commit d1956e5 into next Sep 10, 2024
6 checks passed
@derevnjuk derevnjuk deleted the add-timeout-flag branch September 10, 2024 07:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@derevnjuk derevnjuk derevnjuk approved these changes

Assignees

@maksadbek maksadbek

Labels
Type: enhancement New feature or request.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@maksadbek @derevnjuk