ci: ensure using the package-lock when possible (#422)

NeuraLegion · Aug 1, 2023 · 0c01ca7 · 0c01ca7
1 parent 1d45e55
commit 0c01ca7
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 3 deletions.
diff --git a/.github/workflows/composite/npm/action.yml b/.github/workflows/composite/npm/action.yml
@@ -12,7 +12,7 @@ inputs:
   version:
     description: 'Node.JS version'
     required: false
-    default: 18
+    default: "18"
 
 runs:
   using: 'composite'
@@ -28,7 +28,7 @@ runs:
     - name: Install deps in quiet mode
       shell: bash
       run: |
-        if [[ "${{ inputs.version }}" != "18" ]]; 
+        if [[ "${{ inputs.version }}" < "18" ]]; 
         then
           npm i -q
         else

diff --git a/.github/workflows/deploy.yml b/.github/workflows/deploy.yml
@@ -70,8 +70,10 @@ jobs:
           # it's internally using an old version of `node-gyp`
           - os: windows-2019
             target: win
+            node: 18
           - os: macos-latest
             target: macos
+            node: 18
           # Using the `ubuntu-18.04` runner instead of latest (i.e. `ubuntu-22.04`)
           # because G++/GCC 4.8 is not in an official repository yet.
           - os: ubuntu-22.04
@@ -111,7 +113,7 @@ jobs:
           version: ${{ matrix.node }}
 
       - name: Build executable file
-        run: npm run build:pkg -- -t node${{ matrix.node || 18 }}-${{ matrix.target }}-x64
+        run: npm run build:pkg -- -t node${{ matrix.node }}-${{ matrix.target }}-x64
 
       - name: Copy deps
         if: startsWith(matrix.os, 'win')