Error message when starknet-class-hash command do not work as expected #908

AlejandroLabourdette · 2023-02-09T14:48:43Z

No description provided.

src/utils/utils.ts

swapnilraj · 2023-02-09T15:15:41Z

can you also wrap other places where we invoke starknet cli

AlejandroLabourdette · 2023-02-09T17:54:12Z

can you also wrap other places where we invoke starknet cli

Other places are already wrapped, eg.
I'm not sure that those cases errors are always because of an old starknet version, so I didn't include the recommendation of warp install in the message

src/utils/utils.ts

src/starknetCli.ts

error message when starknet-class-hash command do not work as expected

b0d5ac5

AlejandroLabourdette requested a review from swapnilraj February 9, 2023 14:50

swapnilraj reviewed Feb 9, 2023

View reviewed changes

src/utils/utils.ts Outdated Show resolved Hide resolved

swapnilraj reviewed Feb 9, 2023

View reviewed changes

src/utils/utils.ts Outdated Show resolved Hide resolved

AlejandroLabourdette added 3 commits February 9, 2023 12:59

comments

9607a41

creating a difference between both error messages

b6d1f38

Error with cli test

895e54b

swapnilraj suggested changes Feb 10, 2023

View reviewed changes

src/utils/utils.ts Outdated Show resolved Hide resolved

AlejandroLabourdette added 2 commits February 13, 2023 15:51

more useful errors for starknet commands failed

84b254a

sending output through stdout

eed1f78

AlejandroLabourdette requested a review from swapnilraj February 14, 2023 13:51

AlejandroLabourdette enabled auto-merge (squash) February 15, 2023 14:27

Merge branch 'develop' into starknet-class-hash_command_error_message

f72b16c

AlejandroLabourdette requested a review from cicr99 March 1, 2023 20:58

swapnilraj approved these changes Mar 2, 2023

View reviewed changes

piwonskp reviewed Mar 2, 2023

View reviewed changes

src/utils/utils.ts Outdated Show resolved Hide resolved

piwonskp reviewed Mar 2, 2023

View reviewed changes

src/utils/utils.ts Outdated Show resolved Hide resolved

piwonskp reviewed Mar 2, 2023

View reviewed changes

src/starknetCli.ts Outdated Show resolved Hide resolved

refactor

94e1912

AlejandroLabourdette requested a review from piwonskp March 3, 2023 08:13

wrapper execSyncAndLog

9b7cc87

piwonskp reviewed Mar 6, 2023

View reviewed changes

src/starknetCli.ts Outdated Show resolved Hide resolved

piwonskp reviewed Mar 6, 2023

View reviewed changes

src/starknetCli.ts Show resolved Hide resolved

AlejandroLabourdette added 2 commits March 7, 2023 08:31

refactor options

f307200

Merge branch 'develop' into starknet-class-hash_command_error_message

8f79fe7

piwonskp approved these changes Mar 9, 2023

View reviewed changes

AlejandroLabourdette merged commit cb8d119 into develop Mar 9, 2023

AlejandroLabourdette deleted the starknet-class-hash_command_error_message branch March 9, 2023 21:27

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Error message when starknet-class-hash command do not work as expected #908

Error message when starknet-class-hash command do not work as expected #908

AlejandroLabourdette commented Feb 9, 2023

swapnilraj commented Feb 9, 2023

AlejandroLabourdette commented Feb 9, 2023 •

edited

Loading

Error message when starknet-class-hash command do not work as expected #908

Error message when starknet-class-hash command do not work as expected #908

Conversation

AlejandroLabourdette commented Feb 9, 2023

swapnilraj commented Feb 9, 2023

AlejandroLabourdette commented Feb 9, 2023 • edited Loading

AlejandroLabourdette commented Feb 9, 2023 •

edited

Loading