-
Notifications
You must be signed in to change notification settings - Fork 69
Conversation
The PR requires 0xSpaceShard/starknet-devnet#472 and an update to dependencies before it gets merged |
It's merged now, let's update dependencies for starknet devnet |
I've added the new Warp binary for 1.0.0-rc for arm. Also updated warplib code to be compatible with new version. As soon as someone updates for x86_64, test should start passing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything looks in order to me, however I want to learn more about the approaches taken.
Why do we keep two versions of the corelib for different architectures? What is the difference?
Have we considered the alternative of having a submodule pointing to a particular tag in the StarkWare repository?
Are we set on keeping the binaries in the repo long-term?
We plan to use normal package management long-term, either |
I've made an issue for that #1068 |
I see, thank you. Is that also the reason that we duplicate the library? No reason not too, given that this is temporary anyway? |
Exactly, I guess it was easier that way |
I see the point, but just as a note one symlink would serve well to lessen the code/changes blowup |
No description provided.