Skip to content
This repository has been archived by the owner on Sep 5, 2023. It is now read-only.

Cairo1 bump up to v1.0.0-rc0 #1051

Merged
merged 10 commits into from
May 23, 2023
Merged

Cairo1 bump up to v1.0.0-rc0 #1051

merged 10 commits into from
May 23, 2023

Conversation

AlejandroLabourdette
Copy link
Contributor

No description provided.

@piwonskp
Copy link
Contributor

The PR requires 0xSpaceShard/starknet-devnet#472 and an update to dependencies before it gets merged

@piwonskp
Copy link
Contributor

It's merged now, let's update dependencies for starknet devnet

@rodrigo-pino
Copy link
Contributor

I've added the new Warp binary for 1.0.0-rc for arm. Also updated warplib code to be compatible with new version. As soon as someone updates for x86_64, test should start passing

Copy link
Contributor

@temyurchenko temyurchenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks in order to me, however I want to learn more about the approaches taken.

Why do we keep two versions of the corelib for different architectures? What is the difference?
Have we considered the alternative of having a submodule pointing to a particular tag in the StarkWare repository?
Are we set on keeping the binaries in the repo long-term?

@piwonskp
Copy link
Contributor

Everything looks in order to me, however I want to learn more about the approaches taken.

Why do we keep two versions of the corelib for different architectures? What is the difference? Have we considered the alternative of having a submodule pointing to a particular tag in the StarkWare repository? Are we set on keeping the binaries in the repo long-term?

We plan to use normal package management long-term, either cairo-lang from pip or cairo compiler from cargo. Probably it will be cargo long term

@piwonskp
Copy link
Contributor

I've made an issue for that #1068

@temyurchenko
Copy link
Contributor

I've made an issue for that #1068

I see, thank you. Is that also the reason that we duplicate the library? No reason not too, given that this is temporary anyway?

@piwonskp
Copy link
Contributor

Exactly, I guess it was easier that way

@piwonskp piwonskp merged commit 2075afb into cairo-1.0 May 23, 2023
@piwonskp piwonskp deleted the cairo1-bump-up branch May 23, 2023 18:26
@temyurchenko
Copy link
Contributor

Exactly, I guess it was easier that way

I see the point, but just as a note one symlink would serve well to lessen the code/changes blowup

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants