Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Override empty state scope with the state of the current block #8067

Merged
merged 1 commit into from
Jan 16, 2025
Merged

Override empty state scope with the state of the current block #8067

merged 1 commit into from
Jan 16, 2025

Conversation

flcl42
Copy link
Contributor

@flcl42 flcl42 commented Jan 16, 2025

Changes

  • Always override scope, applying block header
  • Use readonly block tree in taiko?

Types of changes

What types of changes does your code introduce?

  • Bugfix (a non-breaking change that fixes an issue)
  • New feature (a non-breaking change that adds functionality)
  • Breaking change (a change that causes existing functionality not to work as expected)
  • Optimization
  • Refactoring
  • Documentation update
  • Build-related changes
  • Other: Description

Testing

Requires testing

  • Yes
  • No

If yes, did you write tests?

  • Yes
  • No

@flcl42 flcl42 requested a review from LukaszRozmej January 16, 2025 16:40
@flcl42 flcl42 merged commit 1ab5908 into master Jan 16, 2025
79 checks passed
@flcl42 flcl42 deleted the trace-proper-scope branch January 16, 2025 18:42
mralj pushed a commit that referenced this pull request Feb 5, 2025
@flcl42 @mralj
Override empty state scope with the state of the current block (#8067)
f240681
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LukaszRozmej LukaszRozmej LukaszRozmej approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@flcl42 @LukaszRozmej