Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change for 7702 in devnet 5 #7980

Merged
merged 7 commits into from
Dec 30, 2024
Merged

Change for 7702 in devnet 5 #7980

merged 7 commits into from
Dec 30, 2024

Conversation

ak88
Copy link
Contributor

@ak88 ak88 commented Dec 29, 2024

Copy link
Member

@LukaszRozmej LukaszRozmej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

change DecodeULong

@ak88 ak88 requested a review from LukaszRozmej December 30, 2024 13:57
@ak88
Copy link
Contributor Author

ak88 commented Dec 30, 2024

change DecodeULong

fixed

@@ -103,7 +103,7 @@ public static IEnumerable<RlpStream> WrongSizeFieldsEncodedCases()

yield return TupleRlpStream(
//Wrong R size
Enumerable.Range(0, 8).Select(static i => (byte)0xFF).ToArray(),
Enumerable.Range(0, 32).Select(static i => (byte)0xFF).ToArray(),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldn't those be some constants?

@ak88 ak88 merged commit 34d889f into master Dec 30, 2024
79 checks passed
@ak88 ak88 deleted the feature/7702-devnet-5 branch December 30, 2024 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants