Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Share stack pool between threads #7972

Merged
merged 1 commit into from
Dec 30, 2024
Merged

Share stack pool between threads #7972

merged 1 commit into from
Dec 30, 2024

Conversation

benaadams
Copy link
Member

Changes

  • We now have lots of prewarming threads, rpc eth_calls and the main processor isn't thread bonded (is async channels); so we should share the StackPool across all threads rather than having multiple StackPools as ThreadLocals

Types of changes

What types of changes does your code introduce?

  • Optimization

Testing

Requires testing

  • No

@benaadams benaadams merged commit 2cda94d into master Dec 30, 2024
79 checks passed
@benaadams benaadams deleted the share-stack-pool branch December 30, 2024 00:47
rjnrohit pushed a commit that referenced this pull request Jan 11, 2025
@benaadams @rjnrohit
Share stack pool between threads (#7972)
67fd2bc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LukaszRozmej LukaszRozmej LukaszRozmej approved these changes

@asdacap asdacap Awaiting requested review from asdacap

Assignees
No one assigned
Labels
performance is good
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@benaadams @LukaszRozmej