Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix error on fetching header without total difficulty #7948

Merged
merged 2 commits into from
Dec 21, 2024
Merged

Fix error on fetching header without total difficulty #7948

merged 2 commits into from
Dec 21, 2024

Conversation

asdacap
Copy link
Contributor

@asdacap asdacap commented Dec 21, 2024

  • Not sure what real way to trigger this. Could just be a rare race condition.

Types of changes

What types of changes does your code introduce?

  • Bugfix (a non-breaking change that fixes an issue)

Testing

Requires testing

  • Yes
  • No

If yes, did you write tests?

  • Yes
  • No

Notes on testing

  • Unit test can throw, but need to manually delete level info.

@asdacap asdacap merged commit baa8f63 into master Dec 21, 2024
79 checks passed
@asdacap asdacap deleted the fix/fetch-persisted-header-throws-on-orphaned-block branch December 21, 2024 07:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benaadams benaadams benaadams approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@asdacap @benaadams