Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missed bloom filter #7893

Merged
merged 2 commits into from
Dec 12, 2024
Merged

Fix missed bloom filter #7893

merged 2 commits into from
Dec 12, 2024

Conversation

asdacap
Copy link
Contributor

@asdacap asdacap commented Dec 11, 2024

  • It seems that rocksdb does not crash when bloom filter config is invalid unlike other parameter key. This can be verified by looking into rockdb log directly which have the filter set to null.
  • With optimize_filters_for_hits being true by default, the bloom filter is only set for non-last level of the LSM tree which allow a reads to skip the first two level (in case of state) of LSM while saving disk space by not having it on the last level. With cache/prewarming/compaction priority, its unclear if the impact is significant or not except for maybe state sync.
  • Also disable optimize_filters_for_hits for block info, headers and code, to make sync faster maybe as it will not hit a lot during sync.

Types of changes

What types of changes does your code introduce?

  • Bugfix (a non-breaking change that fixes an issue)

Testing

Requires testing

  • Yes
  • No

If yes, did you write tests?

  • Yes
  • No

Notes on testing

  • Checked log manually.

@asdacap asdacap merged commit acb92bd into master Dec 12, 2024
80 checks passed
@asdacap asdacap deleted the fix/missed-bloom-filter branch December 12, 2024 23:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants