Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
optimize_filters_for_hits
being true by default, the bloom filter is only set for non-last level of the LSM tree which allow a reads to skip the first two level (in case of state) of LSM while saving disk space by not having it on the last level. With cache/prewarming/compaction priority, its unclear if the impact is significant or not except for maybe state sync.optimize_filters_for_hits
for block info, headers and code, to make sync faster maybe as it will not hit a lot during sync.Types of changes
What types of changes does your code introduce?
Testing
Requires testing
If yes, did you write tests?
Notes on testing