Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove branch values #7866

Merged
merged 2 commits into from
Dec 6, 2024
Merged

Remove branch values #7866

merged 2 commits into from
Dec 6, 2024

Conversation

benaadams
Copy link
Member

@benaadams benaadams commented Dec 5, 2024 •
edited
Loading

Changes

  • Not used by Ethereum MPT and adds additional complexity to the code

Types of changes

What types of changes does your code introduce?

  • Optimization

Testing

Requires testing

  • No

Notes on testing

Removed some upstream tests that didn't use 32 byte keys

@benaadams benaadams force-pushed the remove-branch-values branch from d8ba41b to b8dd54a Compare December 5, 2024 10:21
@benaadams benaadams marked this pull request as ready for review December 5, 2024 10:42
@LukaszRozmej LukaszRozmej requested a review from asdacap December 5, 2024 19:09
@benaadams benaadams merged commit 8d7593e into master Dec 6, 2024
79 checks passed
@benaadams benaadams deleted the remove-branch-values branch December 6, 2024 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LukaszRozmej LukaszRozmej LukaszRozmej approved these changes

@asdacap asdacap Awaiting requested review from asdacap

Assignees
No one assigned
Labels
performance is good
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@benaadams @LukaszRozmej