Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CliqueBlockProducer to Channels #7846

Merged
merged 2 commits into from
Dec 2, 2024
Merged

CliqueBlockProducer to Channels #7846

merged 2 commits into from
Dec 2, 2024

Conversation

benaadams
Copy link
Member

Changes

  • Wrapping a ConcurrentQueue in a BlockingCollection burns a ton of CPU spinning; whereas its a pattern ideally suited to Channels; and using true async

Types of changes

What types of changes does your code introduce?

  • Optimization
  • Refactoring

Testing

Requires testing

  • No

@benaadams benaadams changed the title CliqueBlockProducer to Channel CliqueBlockProducer to Channels Dec 1, 2024
@benaadams benaadams mentioned this pull request Dec 1, 2024
Merged
3 tasks
@benaadams benaadams merged commit 0d38015 into master Dec 2, 2024
79 checks passed
@benaadams benaadams deleted the cliqueblockproducer-to-channels branch December 2, 2024 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LukaszRozmej LukaszRozmej LukaszRozmej approved these changes

Assignees
No one assigned
Labels
performance is good
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@benaadams @LukaszRozmej