Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stop accepting JsonRpc requests during shutdown #7818

Merged
merged 3 commits into from
Nov 26, 2024
Merged

Stop accepting JsonRpc requests during shutdown #7818

merged 3 commits into from
Nov 26, 2024

Conversation

benaadams
Copy link
Member

Changes

image

  • Reject incoming requests during shutdown; been bugging me for a while :)

Types of changes

What types of changes does your code introduce?

  • Bugfix (a non-breaking change that fixes an issue)

MarekM25
MarekM25 approved these changes Nov 26, 2024
View reviewed changes
Copy link
Contributor

@MarekM25 MarekM25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

However, I think it doesn't cause any issues other than logging.

@benaadams benaadams merged commit 39d8076 into master Nov 26, 2024
79 checks passed
@benaadams benaadams deleted the shutdown branch November 26, 2024 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarekM25 MarekM25 MarekM25 approved these changes

@LukaszRozmej LukaszRozmej Awaiting requested review from LukaszRozmej

@kamilchodola kamilchodola Awaiting requested review from kamilchodola

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@benaadams @MarekM25