Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix inacccurate memory metric due to concurrent writes #7600

Merged
merged 2 commits into from
Oct 14, 2024

Conversation

asdacap
Copy link
Contributor

@asdacap asdacap commented Oct 14, 2024

  • Because the commit is now concurrent, the memory used mettrics need to be modified atomically.
  • Because it was not atomically modified, it use more memory than tracked causing unintended increased pruning interval.

What types of changes does your code introduce?

  • Bugfix (a non-breaking change that fixes an issue)

Testing

Requires testing

  • Yes
  • No

If yes, did you write tests?

  • Yes
  • No

@asdacap asdacap merged commit 8e716e9 into master Oct 14, 2024
73 checks passed
@asdacap asdacap deleted the fix/inaccurate-memory-metric branch October 14, 2024 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants