Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Speed up docker builds #7598

Merged
merged 6 commits into from
Oct 13, 2024
Merged

Speed up docker builds #7598

merged 6 commits into from
Oct 13, 2024

Conversation

benaadams
Copy link
Member

@benaadams benaadams commented Oct 13, 2024

Changes

  • Don't publish ReadyToRun for faster deployment
  • Nethermind is a very long running process so initial startup time isn't so important vs better instrumentation from tier0 to produce improved teir1 code via Jit PGO

Types of changes

What types of changes does your code introduce?

  • Optimization
  • Build-related changes

Testing

Requires testing

  • No

@benaadams benaadams marked this pull request as ready for review October 13, 2024 19:20
@benaadams benaadams requested a review from a team as a code owner October 13, 2024 19:22
Copy link
Contributor

@rubo rubo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should not disable R2R for Docker only. Nethermind builds should not differ depending on distribution channels. If we consider R2R not important, we disable it in general.
The long build times for the Docker image are due to GitHub Actions runners. We can either switch to a more powerful one (~8 mins) or just wait a little more with the current one. It's not a big deal.

@benaadams
Copy link
Member Author

We should not disable R2R for Docker only. Nethermind builds should not differ depending on distribution channels. If we consider R2R not important, we disable it in general. The long build times for the Docker image are due to GitHub Actions runners. We can either switch to a more powerful one (~8 mins) or just wait a little more with the current one. It's not a big deal.

I did disable it everywhere?

@rubo
Copy link
Contributor

rubo commented Oct 13, 2024

I did disable it everywhere?

Then why have it false or 0 explicitly?

@benaadams
Copy link
Member Author

I did disable it everywhere?

Then why have it false or 0 explicitly?

It only applies to publishing; so changed it to false in .csproj

The other one in docker files turns off ReadyToRun for the framework so it Jits everything but that can only be set via environment var not any project or build setting :(

@rubo
Copy link
Contributor

rubo commented Oct 13, 2024

The other one in docker files

Do we need it? Isn't it off by default?

Co-authored-by: Ruben Buniatyan <rubo@users.noreply.github.com>
@rubo rubo self-requested a review October 13, 2024 20:30
Co-authored-by: Ruben Buniatyan <rubo@users.noreply.github.com>
@benaadams benaadams merged commit 6b4b485 into master Oct 13, 2024
73 checks passed
@benaadams benaadams deleted the docker-builds branch October 13, 2024 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants