-
Notifications
You must be signed in to change notification settings - Fork 468
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Speed up docker builds #7598
Speed up docker builds #7598
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should not disable R2R for Docker only. Nethermind builds should not differ depending on distribution channels. If we consider R2R not important, we disable it in general.
The long build times for the Docker image are due to GitHub Actions runners. We can either switch to a more powerful one (~8 mins) or just wait a little more with the current one. It's not a big deal.
I did disable it everywhere? |
Then why have it |
It only applies to publishing; so changed it to The other one in docker files turns off ReadyToRun for the framework so it Jits everything but that can only be set via environment var not any project or build setting :( |
Do we need it? Isn't it off by default? |
Co-authored-by: Ruben Buniatyan <rubo@users.noreply.github.com>
Co-authored-by: Ruben Buniatyan <rubo@users.noreply.github.com>
Changes
Types of changes
What types of changes does your code introduce?
Testing
Requires testing