-
Notifications
You must be signed in to change notification settings - Fork 468
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix OP Stack header validation / Remove snapshot from snap-synced chains #7588
Conversation
The issue seems to be specific to OP-mainnet (I could not reproduce the issue on OP-sepolia) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the PR description you mention:
Removes snapshot from non-archive configs, for op networks that support snap sync
Is this still WIP?
@@ -73,7 +73,7 @@ | |||
"rip7212TransitionTimestamp": "0x668eb001", | |||
"opGraniteTransitionTimestamp": "0x66e1be81", | |||
|
|||
"terminalTotalDifficulty": "0" | |||
"terminalTotalDifficulty": "210470125" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From where are we getting this value?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
that's the total difficulty at the height of bedrock block in op-mainnet
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is it that I see 0
in a block explorer then? https://optimism.blockscout.com/block/0xdbf6a80fef073de06add9b0d14026d6e5a86c85f6d102c36d3d8e9cf89c2afd3
Also, does this PR supersede #7565 ? |
51f4cee
to
8adbbda
Compare
8adbbda
to
f725f5e
Compare
That other PR also gets into fixes in the snapshot download plugin, there is a significant overlap though |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems to have fixed the issue on op-mainet so LGTM!
Changes
OptimismPoSSwitcher
that decides whether block is pre or post merge based on bedrock block numberTypes of changes
What types of changes does your code introduce?
Testing
Requires testing
If yes, did you write tests?
Documentation
Requires documentation update
Requires explanation in Release Notes