-
Notifications
You must be signed in to change notification settings - Fork 461
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BLS precompile native benchmarking & improvements #7544
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR can be merged in this form, you added metrics which is good
Moved the metrics to a different PR: #7546 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you have results? :)
src/Nethermind/Nethermind.Evm/Precompiles/Bls/G1MSMPrecompile.cs
Outdated
Show resolved
Hide resolved
src/Nethermind/Nethermind.Evm/Precompiles/Bls/G2MSMPrecompile.cs
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should we bring those test files directly, are they available in some repo that we could bring as a submodule?
they are in benchmark_precompiles, I could either add the new bls vectors there or copy them all to the same directory as I did |
Resolves #7529
Changes
Types of changes
What types of changes does your code introduce?
Testing
Requires testing
Documentation
Requires documentation update
Requires explanation in Release Notes