Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BLS precompile native benchmarking & improvements #7544

Merged
merged 16 commits into from
Oct 9, 2024

Conversation

Marchhill
Copy link
Contributor

@Marchhill Marchhill commented Oct 3, 2024

Resolves #7529

Changes

  • Benchmark BLS precompile with BenchmarkDotNet (results)
  • Rename precompiles and tests for consistency with EIP
  • Add options to disable concurrency and subgroup checks
  • Optimisations and refactoring
  • Move vectors to bench_precompiles

Types of changes

What types of changes does your code introduce?

  • Bugfix (a non-breaking change that fixes an issue)
  • New feature (a non-breaking change that adds functionality)
  • Breaking change (a change that causes existing functionality not to work as expected)
  • Optimization
  • Refactoring
  • Documentation update
  • Build-related changes
  • Other: Description

Testing

Requires testing

  • Yes
  • No

Documentation

Requires documentation update

  • Yes
  • No

Requires explanation in Release Notes

  • Yes
  • No

Copy link
Contributor

@MarekM25 MarekM25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR can be merged in this form, you added metrics which is good

@Marchhill Marchhill changed the title Bls BenchmarkDotNet and metrics Bls Metrics Oct 3, 2024
@Marchhill Marchhill changed the title Bls Metrics Bls BenchmarkDotNet Oct 3, 2024
@Marchhill
Copy link
Contributor Author

This PR can be merged in this form, you added metrics which is good

Moved the metrics to a different PR: #7546

@Marchhill Marchhill requested a review from MarekM25 October 3, 2024 12:42
Copy link
Contributor

@MarekM25 MarekM25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you have results? :)

Copy link
Member

@LukaszRozmej LukaszRozmej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we bring those test files directly, are they available in some repo that we could bring as a submodule?

@Marchhill
Copy link
Contributor Author

should we bring those test files directly, are they available in some repo that we could bring as a submodule?

they are in benchmark_precompiles, I could either add the new bls vectors there or copy them all to the same directory as I did

@Marchhill Marchhill changed the title Bls BenchmarkDotNet BLS precompile native benchmarking & improvements Oct 9, 2024
@Marchhill Marchhill marked this pull request as ready for review October 9, 2024 11:23
@Marchhill Marchhill merged commit a705c1a into master Oct 9, 2024
67 checks passed
@Marchhill Marchhill deleted the feature/bls-benchmarkdotnet branch October 9, 2024 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Benchmarks and gas costs of 2537
3 participants