Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor and improve DB size generator #7450

Merged
merged 4 commits into from
Sep 20, 2024
Merged

Conversation

rubo
Copy link
Contributor

@rubo rubo commented Sep 17, 2024

Changes

  • Fixed the DB size generator to update the docs for the latest released version along with the next version
  • Refactored command line arguments handling
  • Refactored file handling to avoid back-and-forth with copying of the docs files. No need to copy doc files that should be modified. Now it knows where to look and what to do.
  • Removed "v" from version strings

Types of changes

What types of changes does your code introduce?

  • Bugfix (a non-breaking change that fixes an issue)
  • New feature (a non-breaking change that adds functionality)
  • Breaking change (a change that causes existing functionality not to work as expected)
  • Optimization
  • Refactoring
  • Documentation update
  • Build-related changes
  • Other: Docs generator refactoring

Testing

Requires testing

  • Yes
  • No

Notes on testing

Tested manually.

@rubo rubo added the docs label Sep 17, 2024
@rubo rubo requested a review from kamilchodola September 17, 2024 19:12
@rubo rubo marked this pull request as ready for review September 19, 2024 13:43
@rubo rubo requested a review from a team as a code owner September 19, 2024 13:43
@rubo rubo merged commit 7795c96 into master Sep 20, 2024
67 checks passed
@rubo rubo deleted the feature/docs-dbsize-updater branch September 20, 2024 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants