Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moved BlockProductionTimeout to config, increased BlockProductionTimeout #7378

Merged
merged 7 commits into from
Sep 10, 2024

Conversation

MarekM25
Copy link
Contributor

@MarekM25 MarekM25 commented Sep 2, 2024

Changes

  • Moved BlockProductionTimeout to config
  • Increased BlockProductionTimeout

Types of changes

What types of changes does your code introduce?

  • Bugfix (a non-breaking change that fixes an issue)
  • New feature (a non-breaking change that adds functionality)
  • Breaking change (a change that causes existing functionality not to work as expected)
  • Optimization
  • Refactoring
  • Documentation update
  • Build-related changes
  • Other: Description

Testing

Requires testing

  • Yes
  • No

If yes, did you write tests?

  • Yes
  • No

Notes on testing

Optional. Remove if not applicable.

Documentation

Requires documentation update

  • Yes
  • No

If yes, link the PR to the docs update or the issue with the details labeled docs. Remove if not applicable.

Requires explanation in Release Notes

  • Yes
  • No

If yes, fill in the details here. Remove if not applicable.

Remarks

Optional. Remove if not applicable.

@MarekM25 MarekM25 requested a review from rubo as a code owner September 2, 2024 09:20
@MarekM25 MarekM25 changed the title Moved BlockProductionTimeout to config, increase BlockProductionTimeout Moved BlockProductionTimeout to config, increased BlockProductionTimeout Sep 2, 2024
@@ -26,6 +26,8 @@ public class BlocksConfig : IBlocksConfig

public bool PreWarmStateOnBlockProcessing { get; set; } = true;

public int BlockProductionTimeout { get; set; } = 4000;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BlockProductionTimeoutMs?

@MarekM25 MarekM25 merged commit bd67c5c into master Sep 10, 2024
66 checks passed
@MarekM25 MarekM25 deleted the feature/block_production_timeout branch September 10, 2024 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants