Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Load local key if MiningConfig.Enabled is true #7267

Merged
merged 1 commit into from
Jul 17, 2024

Conversation

LukaszRozmej
Copy link
Member

Fixes #7258 introduced in #6780

Changes

  • Make sure to load key

Types of changes

What types of changes does your code introduce?

  • Bugfix (a non-breaking change that fixes an issue)
  • New feature (a non-breaking change that adds functionality)
  • Breaking change (a change that causes existing functionality not to work as expected)
  • Optimization
  • Refactoring
  • Documentation update
  • Build-related changes
  • Other: Description

Testing

Requires testing

  • Yes
  • No

If yes, did you write tests?

  • Yes
  • No

@LukaszRozmej LukaszRozmej requested a review from rubo as a code owner July 17, 2024 11:38
@LukaszRozmej LukaszRozmej requested a review from ak88 July 17, 2024 11:38
//Don't load the local key if an external signer is configured
if (!miningConfig.Enabled && string.IsNullOrEmpty(miningConfig.Signer))
//Don't load the local key if an external signer is configured
if (string.IsNullOrEmpty(miningConfig.Signer))
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

main change here

@LukaszRozmej LukaszRozmej merged commit aad6777 into master Jul 17, 2024
68 checks passed
@LukaszRozmej LukaszRozmej deleted the fix/local-signerkey-load branch July 17, 2024 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Not mining conensus aura version 1.27.0
2 participants