Feature/geth like system tx

[LukaszRozmej]

Changes

• Decouples system transaction from normal transaction processing
• Makes system transaction support Aura and non-Aura versions
• Moves BeaconBlockRootHandler to use system transactions

Types of changes

What types of changes does your code introduce?

• Bugfix (a non-breaking change that fixes an issue)
• New feature (a non-breaking change that adds functionality)
• Breaking change (a change that causes existing functionality not to work as expected)
• Optimization
• Refactoring
• Documentation update
• Build-related changes
• Other: Description

Testing

Requires testing

• Yes
• No

If yes, did you write tests?

• Yes
• No

Notes on testing

Sync some Aura chains in archive.

Documentation

Requires documentation update

• Yes
• No

Requires explanation in Release Notes

• Yes
• No

[MarekM25]

Is it needed? I don't understand the idea

[MarekM25]

in what conditions value should be subtract in system calls?

[LukaszRozmej]

estimateGas

[MarekM25]

Can we check NoValidation options in PayValue in SystemTransactionProcessor instead of OriginalValidate?

[LukaszRozmej]

No, as we force NoValidation

[LukaszRozmej]

OriginalValidate was introduced due to this condition. For every other condition validation off is equivalent with transaction being system transaction, but for this one condition we need to decouple this logic, and even if it is system transaction validation can be on/off independently, this is used in eth_estimateGas

[MarekM25]

Ok, thanks. I understand the logic. On the other hand, this logic assumes that there are sysCalls that pay values. Based on my quick check, that’s not the case. In sysCalls, we set Value = 0. This means we could simplify the original check and remove that hacky edge case flag.

So original logic could be:
if (validate && !tx.IsSystem())
then we don't need the OriginalValidate at all

[LukaszRozmej]

estimateGas

[LukaszRozmej]

No, as we force NoValidation

[MarekM25]

@kamilchodola this PR will need a special attention from QA team (pls don't start now, wait for green-light). We will have to test AuRa sys calls.

Recommended things:

• resync our gnosis archive
• sync Energyweb/volta archive/non-archive
• sync Chiado
• perhaps, update validators (but could be done with normal cycle)

If we have any working Posdao tests than we could use it, but I guess it's not possible

[benaadams]

Aura failure looks legit (after a number of reruns)

Failed priority_should_return_correctly [77 ms]
Error Message:
Expected root to be a collection with 3 item(s), but {0x942921b14f1b1c385cd7e0cc2ef7abe5598c8358.00000000=4@Contract.2, 0x942921b14f1b1c385cd7e0cc2ef7abe5598c8358.00010203=3@Contract.2}
contains 1 item(s) less than
{0x942921b14f1b1c385cd7e0cc2ef7abe5598c8358.00010203=3@Contract.2, 0xb7705ae4c6f81b66cdb323c65f4e8133690fc099.00000000=1@Contract.1, 0x942921b14f1b1c385cd7e0cc2ef7abe5598c8358.00000000=4@Contract.1}.

[tanishqjasoria]

I still do not understand the use of OriginalValidate, is it supposed to be for a case in future where we transfer value in SystemTransaction? because AFAIK we dont do that right now?