-
Notifications
You must be signed in to change notification settings - Fork 461
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Option to run Discovery V4 and V5 on the same port #7213
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…); fix op decoder
Co-authored-by: Nikita Mescheryakov <root@nikitam.io>
This reverts commit 8e37997.
alexb5dh
commented
Jul 28, 2024
flcl42
approved these changes
Jul 29, 2024
src/Nethermind/Nethermind.Network.Discovery.Test/NettyDiscoveryHandlerTests.cs
Outdated
Show resolved
Hide resolved
alexb5dh
force-pushed
the
discv5-v4-same-port
branch
from
August 5, 2024 12:31
806a358
to
ae96529
Compare
asdacap
reviewed
Aug 8, 2024
src/Nethermind/Nethermind.Network.Discovery/Discv5/NettyDiscoveryV5Handler.cs
Show resolved
Hide resolved
asdacap
reviewed
Aug 8, 2024
src/Nethermind/Nethermind.Network.Discovery/CompositeDiscoveryApp.cs
Outdated
Show resolved
Hide resolved
asdacap
reviewed
Aug 8, 2024
src/Nethermind/Nethermind.Network.Discovery/Discv5/DiscoveryV5App.cs
Outdated
Show resolved
Hide resolved
asdacap
reviewed
Aug 8, 2024
src/Nethermind/Nethermind.Network.Discovery/Discv5/NettyDiscoveryV5Handler.cs
Outdated
Show resolved
Hide resolved
asdacap
approved these changes
Aug 8, 2024
alexb5dh
force-pushed
the
discv5-v4-same-port
branch
from
August 12, 2024 17:25
496c199
to
9c971c1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IDatagramChannel
) is used.IUdpConnection
.DiscoveryApp
to a newDiscoveryConnectionsPool
.InitializeNetwork
to a newCompositeDiscoveryApp
.Depends on Pier-Two/Lantern.Discv5#105 being published on Nuget