catch rlp exception: debug_traceBlock

[rjnrohit]

Fixes #7195

Please choose one of the keywords above to refer to the issue this PR solves followed by the issue number (e.g. Fixes #000). If no issue number, remove the line. Also, remove everything marked optional that is not applicable. Remove this note after reading.

Changes

• List the changes

Types of changes

What types of changes does your code introduce?

• Bugfix (a non-breaking change that fixes an issue)
• New feature (a non-breaking change that adds functionality)
• Breaking change (a change that causes existing functionality not to work as expected)
• Optimization
• Refactoring
• Documentation update
• Build-related changes
• Other: Description

Testing

Requires testing

• Yes
• No

If yes, did you write tests?

• Yes
• No

Notes on testing

Optional. Remove if not applicable.

Documentation

Requires documentation update

• Yes
• No

If yes, link the PR to the docs update or the issue with the details labeled docs. Remove if not applicable.

Requires explanation in Release Notes

• Yes
• No

If yes, fill in the details here. Remove if not applicable.

Remarks

Optional. Remove if not applicable.

[LukaszRozmej]

Can you take a look also what happens in debug_traceBlockByNumber and debug_traceBlockByHash on genesis block?

[rjnrohit]

Can you take a look also what happens in debug_traceBlockByNumber and debug_traceBlockByHash on genesis block?

I'm getting similar errors , I added exception for them as well

{
    "jsonrpc": "2.0",
    "error": {
        "code": -32603,
        "message": "Internal error",
        "data": "System.Reflection.TargetInvocationException: Exception has been thrown by the target of an invocation.\n ---> System.ArgumentNullException: Value cannot be null. (Parameter 'block')\n   at System.ArgumentNullException.Throw(String paramName)\n   at System.ArgumentNullException.ThrowIfNull(Object argument, String paramName)\n   at Nethermind.Consensus.Tracing.GethStyleTracer.TraceBlock(Block block, GethTraceOptions options, CancellationToken cancellationToken) in /_/src/Nethermind/Nethermind.Consensus/Tracing/GethStyleTracer.cs:line 196\n   at Nethermind.JsonRpc.Modules.DebugModule.DebugRpcModule.debug_traceBlockByHash(Hash256 blockHash, GethTraceOptions options) in /_/src/Nethermind/Nethermind.JsonRpc/Modules/DebugModule/DebugRpcModule.cs:line 190\n   at InvokeStub_IDebugRpcModule.debug_traceBlockByHash(Object, Span`1)\n   at System.Reflection.MethodBaseInvoker.InvokeWithFewArgs(Object obj, BindingFlags invokeAttr, Binder binder, Object[] parameters, CultureInfo culture)\n   --- End of inner exception stack trace ---\n   at System.Reflection.MethodBaseInvoker.InvokeWithFewArgs(Object obj, BindingFlags invokeAttr, Binder binder, Object[] parameters, CultureInfo culture)\n   at Nethermind.JsonRpc.JsonRpcService.ExecuteAsync(JsonRpcRequest request, String methodName, ResolvedMethodInfo method, JsonRpcContext context) in /_/src/Nethermind/Nethermind.JsonRpc/JsonRpcService.cs:line 169"
    },
    "id": 1
}

[LukaszRozmej]

I think this can't happen here as it is RLP

[rjnrohit]

It can be inside the TraceBlock function

[MarekM25]

What will we return for genesis after this PR?
What about debug_traceTransaction and other tracing methods?

[rjnrohit]

What will we return for genesis after this PR? What about debug_traceTransaction and other tracing methods?

In case of genesis block, the results are

{
    "jsonrpc": "2.0",
    "result": [],
    "id": 1
}

for both the cases. And, for debug_traceTransaction & other tracing methods , exceptions are being handled imo. Also, ArgumentNullExceptions won't occur for them.