Throw on non-empty storage

[flcl42]

Fixes some hive tests

Clarifications

The check is applied in two places: on top level - when we have a create contract transacation; in a CREATE/CREATE call.
On top level we should not expect storqage to be non zero because selfdestructed contract - so we don't need to clean up
When CREATE* call is executed we return due to collision and do not reach post-selfdestruct clean up
We revert in any case

Changes

• Throw on non-empty storage according to EIP-7610
• Save from metrics failures
• Update tests

Types of changes

What types of changes does your code introduce?

• Bugfix (a non-breaking change that fixes an issue)
• New feature (a non-breaking change that adds functionality)
• Breaking change (a change that causes existing functionality not to work as expected)
• Optimization
• Refactoring
• Documentation update
• Build-related changes
• Other: Description

Testing

Requires testing

• Yes
• No

If yes, did you write tests?

• Yes, will add a bit later
• No

[benaadams]

Does it need to be gated behind an eip7610 chianspec flag?

Also has test submodule changes in PR, not sure if you want those

[flcl42]

Does it need to be gated behind an eip7610 chianspec flag?

Rare case of retroactive application, starting from block 0

Also has test submodule changes in PR, not sure if you want those

Yup, it's an Ethereum tests update.

[benaadams]

Does it need to be gated behind an eip7610 chianspec flag?

Rare case of retroactive application, starting from block 0

Yeah but does it apply to every chain?

Could it cause consensus issue if we include it in next release but other EL's haven't included it yet?

[flcl42]

Does it need to be gated behind an eip7610 chianspec flag?

Rare case of retroactive application, starting from block 0

Yeah but does it apply to every chain?

Yes

Could it cause consensus issue if we include it in next release but other EL's haven't included it yet?

Should not, the case covers theoretically possible collision, that are not expected to happen in practice. And some clients already added it the same way

And if some custom chain would try to make use of just storage accounts, we would be aware of that.