Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use OP tx processor in trace RPC module #7118

Merged
merged 8 commits into from
Jun 7, 2024
Merged

Use OP tx processor in trace RPC module #7118

merged 8 commits into from
Jun 7, 2024

Conversation

flcl42
Copy link
Contributor

@flcl42 flcl42 commented May 31, 2024

Types of changes

What types of changes does your code introduce?

  • Bugfix (a non-breaking change that fixes an issue)
  • New feature (a non-breaking change that adds functionality)
  • Breaking change (a change that causes existing functionality not to work as expected)
  • Optimization
  • Refactoring
  • Documentation update
  • Build-related changes
  • Other: Description

Testing

Requires testing

  • Yes
  • No

If yes, did you write tests?

  • Yes
  • No

Notes on testing

Documentation

Requires documentation update

  • Yes
  • No

Requires explanation in Release Notes

  • Yes
  • No

@flcl42 flcl42 force-pushed the op-trace branch 6 times, most recently from 8df035e to c4282ed Compare May 31, 2024 13:39
@flcl42 flcl42 marked this pull request as ready for review June 3, 2024 07:47
@flcl42 flcl42 requested a review from LukaszRozmej June 4, 2024 08:30
Base automatically changed from fix/op-receipts-rpc to master June 5, 2024 15:34
@flcl42 flcl42 requested a review from asdacap June 6, 2024 14:36
deffrian
deffrian approved these changes Jun 6, 2024
View reviewed changes
Copy link
Contributor

@deffrian deffrian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@flcl42 flcl42 merged commit 3df20d2 into master Jun 7, 2024
68 checks passed
@flcl42 flcl42 deleted the op-trace branch June 7, 2024 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmederosalvarado jmederosalvarado jmederosalvarado approved these changes

@deffrian deffrian deffrian approved these changes

@LukaszRozmej LukaszRozmej Awaiting requested review from LukaszRozmej

@asdacap asdacap Awaiting requested review from asdacap

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@flcl42 @deffrian @jmederosalvarado